Skip to content

Peer review: "thank the contributor" should show snackbar instead of notification #4906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-raoul opened this issue Mar 20, 2022 · 7 comments · Fixed by #4914
Closed

Peer review: "thank the contributor" should show snackbar instead of notification #4906

nicolas-raoul opened this issue Mar 20, 2022 · 7 comments · Fixed by #4914
Assignees
@arinmodi
Labels
enhancement peer review

Comments

@nicolas-raoul
Copy link
Member

adb
@nicolas-raoul nicolas-raoul mentioned this issue Mar 20, 2022
Closed
@arinmodi
Copy link
Contributor

I want to work on this

@arinmodi
Copy link
Contributor

arinmodi commented Mar 20, 2022 •
edited
Loading

Screenshot_20220320-152617~3

@nicolas-raoul, Is this ok ?

@nicolas-raoul
Copy link
Member Author

Seeing this now, I am a bit worried about usability. Performing peer review usually means tapping about 1 button per second, so the button being hidden impacts productivity.

@arinmodi
Copy link
Contributor

I think it will not a major issue cause we are displaying the snackbar for a sec and there is also a sec delay before the user start the next review because of the loading of the image. So it will not affect the user.

@arinmodi
Copy link
Contributor

@nicolas-raoul, please update on this

@nicolas-raoul
Copy link
Member Author

If you believe it does not hinder fast peer review, please send a pull request and we will be able to try it out.
Thanks!

arinmodi added a commit to arinmodi/apps-android-commons that referenced this issue Mar 21, 2022
@arinmodi
Fixed commons-app#4906 : Peer review: "thank the contributor" should …
4043453 
…show snackbar instead of notification
@arinmodi arinmodi mentioned this issue Mar 21, 2022
Merged
@arinmodi
Copy link
Contributor

made the pr

neslihanturan pushed a commit that referenced this issue Apr 25, 2022
@arinmodi
Fixed #4906 : Peer review: "thank the contributor" should show snackb… (
1ae013d 
#4914)

* Fixed #4906 : Peer review: "thank the contributor" should show snackbar instead of notification

* changes the snackbar to toast

* added the tests

* minor changes

* minor changes - 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arinmodi arinmodi

Labels
enhancement peer review
Projects
None yet
Milestone
No milestone
2 participants
@nicolas-raoul @arinmodi