Requesting location permission popup opens app's settings instead of location settings

[RitikaPahwa4444]

Summary

A "Requesting location permission" popup is used at various places in the app (like Explore fragment map and also in PR #5249) that asks users to turn location on for all apps in the Settings. The Settings button, however, takes the user to the app's settings instead of location settings where users can turn their GPS on.

Steps to reproduce

1. Open the map in the Explore fragment
2. Tap on the target icon
3. A popup asking for location access is shown. Allow the app to access location
4. Another popup titled "Requesting location permission" is displayed in case GPS is turned off on the device
5. Tap on Settings

Expected behaviour

Tapping on Settings should take the users to location settings page where they can enable GPS.

Actual behaviour

The app's settings page is displayed instead of location settings. Since the user has already allowed location access in step 3, displaying this page isn't helpful.

Side note: The same button opens location settings page correctly on some devices.

Device name

Moto g62

Android version

12

Commons app version

master and prodDebug

Device logs

No response

Screen-shots

No response

Would you like to work on the issue?

None

[sivaraam]

A PR comment related to this issue.

[paco-arana]

Is this issue still open? I'd like to be assigned to work on it.

[nicolas-raoul]

@paco-arana You are very welcome to submit a pull request. :-)
For this particular issue, please be aware that our GSoC student Ritika may choose to fix it without prior warning if she so desires, but if you are able to fix it promptly that should be fine! In any case, please share your findings regularly, even sharing what does not work :-) Thanks!

[rohit9625]

I am getting first popup for sure but instead of a popup again, a Toast is shown like this :-

[sivaraam]

@rohit9625 That may be due to some recent changes related to migrating to OSM maps. Would you be able to analyse the rrot cause for the same?

[ShashwatKedia]

@sivaraam @rohit9625 for me the toast displays a different message. But when I click the target icon again (after giving permission) it correctly prompts me to turn on the location and take me to the location settings only.

[rohit9625]

@ShashwatKedia you are right.
The same worked for me after giving permission.
So issue seems to be resolved I guess.

[ShashwatKedia]

So issue seems to be resolved I guess.

@rohit9625 I think it's not resolved because, ideally, on giving permission for location, the app should automatically ask to turn on location (if not on) and show the map accordingly. This is not being implemented, as the user has to click the target button again for the app to ask to turn on the location.

[rohit9625]

@ShashwatKedia you are right. It should work like as you told.
So may I work on this issue or someone is already on it?

[ShashwatKedia]

@rohit9625 I found that inside the locationPermissionGranted() function, if the lastKnownLocation is null, then we only display a toast to user, instead of showing dialog to turn on the location. This can be implemented by calling showLocationOffDialog() when location is null.

Here:

[sivaraam]

So may I work on this issue or someone is already on it?

No one else is working on this issue. You could feel free to work on it 🙂

[rohit9625]

Hey guys,
Sorry for being inactive on this issue. I was reproducing the issue again and I faced this error:
Error fetching nearby placed Attempt to read from null... See this video.

WhatsApp.Video.2024-01-14.at.21.42.11_4aa5ed18.mp4

Also, on the logcat an error returned as a response from Wikimedia API. Saying this
{ "error": { "code": "invalid-coord", "info": "Invalid coordinate provided", "docref": "See https://commons.wikimedia.beta.wmflabs.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/postorius/lists/mediawiki-api-announce.lists.wikimedia.org/> for notice of API deprecations and breaking changes." }, "servedby": "deployment-mediawiki11" }

Does anyone know about the code from where this request was sent?