-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Do not filter out category that exactly matches the search #5285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey as a new coder i would be glad to dive into this issue. Please assign it to me, |
@iligeoili: Please start on it after you have sent a pull request for #5279, thanks a lot! :-) |
I think I can do this is @iligeoili is okay with it. |
@Deanstirrat It is yours, thanks! Please let us know about your progress every week or so. 🙂 |
@nicolas-raoul Will do thanks! |
Made the changes I think will fix the issue but cannot run tests until #5208 is resolved |
Context
In the categories selection dialog, when searching for "2021 in Japan", I get
No categories found
despite the existence of https://commons.wikimedia.org/wiki/Category:2021_in_JapanThis is because we filter out old year-based categories, which is a good thing (see https://github.com/commons-app/apps-android-commons/pull/1134/files #1134)
However, when sorting old pictures, such a category is still useful to people who know exactly what they are looking for.
Task
If a category is an exact match for the search string entered, do not filter it out.
Example 1: When "2021 in Japan" is entered, do not filter out the element related to https://commons.wikimedia.org/wiki/Category:2021_in_Japan
Example 2: When "2021 Japan" is entered, the current filtering should run as usual (meaning the element related to https://commons.wikimedia.org/wiki/Category:2021_in_Japan is not shown) because "2021 Japan" does not match ""2021 in Japan" exactly.
The text was updated successfully, but these errors were encountered: