Skip to content

Target the latest Android version #5279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolas-raoul opened this issue Sep 5, 2023 · 8 comments · Fixed by #5296
Closed

Target the latest Android version #5279

nicolas-raoul opened this issue Sep 5, 2023 · 8 comments · Fixed by #5296

Comments

@nicolas-raoul
Copy link
Member

We must increase targetSdk in the manifest.

This is needed for release to Play Store.

@iligeoili
Copy link

I would be glad to help , please assign this issue to me.

@nicolas-raoul
Copy link
Member Author

nicolas-raoul commented Sep 9, 2023

Looking forward to your pull request @iligeoili :-)

@nicolas-raoul
Copy link
Member Author

@iligeoili Any progress on this? Have you found the manifest, and the value of the latest version? 🙂

@shankarpriyank
Copy link
Contributor

@nicolas-raoul @iligeoili I guess we will need to add a couple of lines here.
And if this is what I think this might help

@nicolas-raoul
Copy link
Member Author

Please set compileSdkVersion and compileSdkVersion to 33 in both app/build.gradle and data-client/build.gradle, then test the app and make sure unit tests are running successfully.

If no pull request from @iligeoili within 24 hours, @shankarpriyank feel free to can take over it.

Thanks both! :-)

@shankarpriyank
Copy link
Contributor

I think I wont be able to fix this, cause I have the latest android studio version and I will be blocked until #5208 is merged

@RitikaPahwa4444
Copy link
Collaborator

I can take it up if no one is currently working on it :)

@nicolas-raoul
Copy link
Member Author

wow thanks so much Ritika!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants