Skip to content

[Bug]: Switching languages doesn't seem to work properly #5501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chenhuicui opened this issue Jan 31, 2024 · 8 comments · Fixed by #5560
Closed

[Bug]: Switching languages doesn't seem to work properly #5501

chenhuicui opened this issue Jan 31, 2024 · 8 comments · Fixed by #5560
Assignees

Comments

@chenhuicui
Copy link

Summary

Switching languages doesn't seem to work properly. After clicking on the language setting item on the settings page, change the language to Simplified Chinese and return to the main page with the text still in English.

Steps to reproduce

  1. install the app from f-droid, version 4.2.1
  2. open the app without login
  3. go to the setting page
  4. change the language from English to Chinese [zh-hans]
  5. back to main page

Expected behaviour

app UI language should be Chinese

Actual behaviour

In English

Device name

huawei nova 5 pro

Android version

android 10

Commons app version

4.2.1

Device logs

No response

Screen-shots

No response

Would you like to work on the issue?

None

@chenhuicui chenhuicui added the bug label Jan 31, 2024
@nicolas-raoul
Copy link
Member

You are right, I have noticed that too.
Do you know any app where such a setting works immediately? Ideally open source so that we can see how they do, but otherwise is good to, to assure feasibility.
Thanks!

@rohit9625
Copy link
Contributor

This behavior is the same for all languages. The UI is not being populated with the new set Language.
Well, how long have you been facing this problem @chenhuicui?
I would like to work on it, @nicolas-raoul : )

@chenhuicui
Copy link
Author

I'm sorry, I am a tester and not a professional Android developer, so I am unsure how to proceed. I discovered the issue during the automation testing process of the application. Thank you for your reply, and I wish you all the best. @nicolas-raoul @rohit9625

@geektan123
Copy link

please assign me the issue #5501 @nicolas-raoul

@nicolas-raoul
Copy link
Member

@geektan123 Sorry Rohit asked first, but there are many other issues for you to choose from. 🙂

@sivaraam
Copy link
Member

sivaraam commented Feb 8, 2024

You are right, I have noticed that too. Do you know any app where such a setting works immediately? Ideally open source so that we can see how they do, but otherwise is good to, to assure feasibility.

I've seen the My Expenses app handle this neatly. The code is available here: https://github.com/mtotschnig/MyExpenses

@rohit9625
Copy link
Contributor

Thank you so much for this reference👍

@rohit9625
Copy link
Contributor

Hello!!
Mr. @nicolas-raoul please have a look at the linked PR and tell me if any other changes are required :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants