-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Change line break behaviour of description template #5523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Just to be clear, you'd like the wikicode to be like below, right?
|
Yes, exactly. |
Hey! I'm an open-source newbie, and I'd love to take up this issue. |
@ivanacha It is yours, thanks! 🙂 |
👍Working on it right now
|
Added line breaks to PageContentsCreator.java, CategoryEditHelperUnitTests.kt, and MediaDetailFragmentUnitTests.kt following the example given on issue commons-app#5523.
@Speravir Thanks to Ivan's contribution the issue seems fixed now:
https://commons.wikimedia.org/wiki/File:Harmonica_Yokocho_4.jpg |
Added line breaks to PageContentsCreator.java, CategoryEditHelperUnitTests.kt, and MediaDetailFragmentUnitTests.kt following the example given on issue #5523.
Yes, it apparently looks like this, thanks to @ivanacha (I had noticed #5562 myself days ago). But I will only confirm, after @OpenGreenStreet will have uploaded some files with proper wikitext. 😁 Just joking. I assume he simply needs an update, isn’t he? |
I would assume the same. I currently still have version 4.2.1~14b6c455b and there are currently no updates for me in the Play Store. |
Added line breaks to PageContentsCreator.java, CategoryEditHelperUnitTests.kt, and MediaDetailFragmentUnitTests.kt following the example given on issue commons-app#5523.
Description
Caveat: I’m not a Commons app user and so do not know it at all. Hence I may make some wrong assumptions.
I frequently work in the source of file descriptions and noticed a strange behaviour regarding a line break in a place I wouldn’t set it. Instead, I miss a line break, where I’ve expected one. These (missing) line breaks do not any harm for the output, so this is not urgent, but should anyway be easy to fix. Look at source of example file File:20240128 xl 1147-Treffpunkt Freizeit.jpg. It looks like this (stripped last lines and most values from template parameters):
Between the parameters
|description
and|source
there is a spurious line I’d love to be removed. But then after the{{Location}}
template and before the header for the license section I miss a line break.I noticed this a while ago, but recently asked @OpenGreenStreet for the reason and he pointed my to the App as cause of this.
Also ping @nicolas-raoul who, as well, recommended opening an issue for this. Here is an example file uploaded by him with the same source appearance: File:2004 Commons Android app - Metadata selection.png. This has, of course, no Location template, and therefore the license header follows straight after the information template.
The text was updated successfully, but these errors were encountered: