Skip to content

Remove Mapbox from CREDITS #5611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kanahia1 opened this issue Mar 7, 2024 · 2 comments · Fixed by #5617
Closed

Remove Mapbox from CREDITS #5611

kanahia1 opened this issue Mar 7, 2024 · 2 comments · Fixed by #5617
Labels
enhancement good first issue

Comments

@kanahia1
Copy link
Contributor

kanahia1 commented Mar 7, 2024

Since we have successfully replaced MapBox. Should we also remove it from CREDITS ?
https://github.com/commons-app/apps-android-commons/blob/main/CREDITS

If yes, label : good first issue
@0x11110
Copy link

0x11110 commented Mar 9, 2024

May I?

k-rajesh added a commit to k-rajesh/apps-android-commons that referenced this issue Mar 9, 2024
@k-rajesh
commons-app#5611 removed MapBox from CREDIS because it has already be…
d86e8ac 
…en replaced
@k-rajesh k-rajesh mentioned this issue Mar 9, 2024
Merged
@whym
Copy link
Collaborator

whym commented Mar 11, 2024

I didn't follow the transition closely, but it looks like there is still some mapbox code in the repository? Searching "mapbox" gives me 30 hits (files).

nicolas-raoul pushed a commit that referenced this issue Mar 18, 2024
@k-rajesh
#5611 removed MapBox from CREDIS because it has already been replaced (…
23492ab 
…#5617)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#5611 removed MapBox from CREDIS because it has already been replaced k-rajesh/apps-android-commons
4 participants
@whym @nicolas-raoul @kanahia1 @0x11110