Skip to content

Allow retention, export/import for settings to prevent its loss #5766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OpenGreenStreet opened this issue Jul 9, 2024 · 11 comments
Open

Comments

@OpenGreenStreet
Copy link

What is the user problem or growth opportunity you want to see solved?

If a user changes their password, the Commons app will not be notified. It is then no longer possible to upload images. To upload images again, the user must log out and log in again. The user-specific settings (especially EXIF tags) will be lost. Relogin without losing user-specific settings (especially EXIF tags)

How do you know that this problem exists today? Why is this important?

The user-specific settings (especially EXIF tags) will be lost.

Who will benefit from it?

All users

Anything else you would like to add?

No response

@sivaraam
Copy link
Member

sivaraam commented Jul 9, 2024

We could try to solve this by giving a general setting export/import option. The relogin would help your specific case but a settings export/import option would be more helpful as it would generally give an option to restore the settings, say, when the user switches to a new device.

@sivaraam sivaraam changed the title Relogin without loss of user-specific settings (especially EXIF tags) Allow export/import for settings to prevent its loss Jul 9, 2024
@psh
Copy link
Collaborator

psh commented Jul 11, 2024

Other apps sometimes have an option for "logout and remember my details" verses "logout and forget me". It seems like a lot of work for users to have to remember to export and re-import when it could be a simple option as part of logout.

@OpenGreenStreet
Copy link
Author

@psh Exactly, you can get by with it if you check the settings after logging in again. But it would be very convenient if the app did this automatically.

@sivaraam
Copy link
Member

Got it. So, I think a option like "Remember my settings" during logout is what we feel would be beneficial. Does that seem right?

I think we could the settings export/import migjt still be helpful for other use cases.

@sivaraam sivaraam changed the title Allow export/import for settings to prevent its loss Allow retention, export/import for settings to prevent its loss Jul 12, 2024
@OpenGreenStreet
Copy link
Author

@sivaraam : yes, "Remember my settings" would be very nice

@parneet-guraya
Copy link
Contributor

We're clearing preferences on logout. There are two types of logout events where this preference is cleared ->

  • Intentional, when user click on logout.
  • Unintentional, when we get InvalidLoginTokenException and app logs out. Don't know when this occurs maybe when user change password from other client?

I think we should prompt the user when there's Intentional log out and ask in a checkbox if want to remember the settings or not.

In case of Unintentional log outs user may expect their settings to be preserved.

@OpenGreenStreet What do you think?

@parneet-guraya
Copy link
Contributor

@nicolas-raoul hi, I'd love your input too. See my previous comment :)

@nicolas-raoul
Copy link
Member

I think we should prompt the user when there's Intentional log out and ask in a checkbox if want to remember the settings or not.
In case of Unintentional log outs user may expect their settings to be preserved.

Sounds reasonable to me! :-)

@OpenGreenStreet
Copy link
Author

@parneet-guraya : Please excuse the late reply:

  • "In case of Unintentional log outs user may expect their settings to be preserved."
    ** That is exactly the point. Every time I had a problem, it was because I had changed my password with the Wikipedia web interface. The next time I used the Commons app, I didn't remember this and had problems uploading images. There was no meaningful hint.
    It would be important to me that all settings are retained in this case.

@parneet-guraya
Copy link
Contributor

Okay, so we can have feature for storing/restoring settings or preferences. Then it would depend when it will work based on

  • If Unintentional logout -> always enabled.
  • If Intentional logout -> ask user if want to remember settings or not.

@nicolas-raoul Can I start working on this? :-)

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Jan 2, 2025

Is there any drawback to having it always enabled, even for intentional logouts? Users who want to wipe their settings can use Android's UI for that. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants