Skip to content

Nearby pins: Make it easier to understand what the colors mean #5841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolas-raoul opened this issue Sep 30, 2024 · 2 comments · Fixed by #5881
Closed

Nearby pins: Make it easier to understand what the colors mean #5841

nicolas-raoul opened this issue Sep 30, 2024 · 2 comments · Fixed by #5881

Comments

@nicolas-raoul
Copy link
Member

Current meaning:

Red: There is a Wikidata item here, and no picture yet.
Green: There is a Wikidata item here, with a picture already.
Grey: There is a Wikidata item here, and the app is currently retrieving whether it has a picture already or not.

Any idea on making that more understandable is welcome. :-)

Maybe a first-time explanation popup, or a legend? Ideally it should not take much screen space, or be hideable.

@hannagnourt
Copy link
Contributor

Hi, I'm doing a group assignment and we would like to work on this. Could I please get assigned this issue? Thank you!

@nicolas-raoul
Copy link
Member Author

@hannagnourt It is yours, thanks! Looking forwards to your pull request. :-)

nicolas-raoul added a commit that referenced this issue Oct 22, 2024
… colors mean (#5881)

* UI design for legend to explain the colors of the nearby pins

* Add listener for the button to toggle the visibility of the legend (make it hideable)

* Change wording for legend and make text localizable

* Fixed typo

* Fixed typo

---------

Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants