SPARQL: Item label does not seem to follow configured language, "en" hard-coded #5855
Comments
|
Could I have a go at this ? |
|
After replacing, please test with various languages and post screenshots showing Nearby with a famous Wikidata item selected, for instance https://www.wikidata.org/wiki/Q243 Thanks! |
|
I have been able to implement the required changes. But I would like to clarify the expected behaviour for testing. My understanding of the test is to select a famous Wikidata item in the nearby page and ensure that the tags with the native language is given preference. Is this correct ? |
|
Since the explore page doesn't have a search button, I found a nearby item that had a tag in French and English. I had swapped the languages to check if the label that closely matches the user language is retrieved. Item Wikidata
English
French:
|
|
Couple more tests were done with the Bust of Gustave Eiffel link, The langages tested were, French, Armenian, Arabic & Turkish. Before each screenshot was taken, language preference was updated and then the item was located in Nearby. P.S: I tried real hard to locate and retrieve info about Eiffel Tower however, despite mocking the exact co-ordinates of its location, I was unable to locate / retrieve its details. 
|
|
Looks great! |
…figured language.
…ation of Wiki Item (#5864) * (fixes #5855) fetch item label in nearby based on user configured language. * implement a method to delete Place entity from database * clear the cache for a item when a wikiItem is updated. * fix style issue * Update placesRepository on successful WikiItemEdit * Revert the delete operations added to the PlaceDAO * Set name of the place to avoid race condition with NearbyParentFragment. Update Success Notification to show only after the pin has been updated. * Clean-up --------- Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
https://github.com/commons-app/apps-android-commons/blob/main/app/src/main/resources/queries/query_for_item.rq#L21
Problem:
"en"is hard-coded for item labelReplacing with
"${LANG}"might be enough to fix the issue.The text was updated successfully, but these errors were encountered: