Skip to content

Nearby: show cached pins even when internet unavailable #6051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-raoul opened this issue Dec 20, 2024 · 1 comment · Fixed by #6081
Closed

Nearby: show cached pins even when internet unavailable #6051

nicolas-raoul opened this issue Dec 20, 2024 · 1 comment · Fixed by #6081
Assignees
@savsch
Labels
enhancement nearby

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Dec 20, 2024 •
edited
Loading

Users without a mobile plan will appreciate.

Currently, if there is no internet then Nearby does not load any pins, even those that I know exist in cache, and just shows "Internet unavailable":

Screenshot_20241221-003856.png

It will probably require adding coordinates to the cache.
@savsch
Copy link
Contributor

savsch commented Dec 21, 2024

I am excited to work on this. Can I be assigned?

This will require changing the schema a tiny bit (should be limited to simply making Place.location @Embedded), so that the coordinates get stored as floating point values, to support the required query.

@savsch savsch mentioned this issue Dec 26, 2024
Merged
nicolas-raoul added a commit that referenced this issue Dec 26, 2024
@savsch @nicolas-raoul
Nearby: show cached pins even when internet is unavailable (fixes #6051…
75ca96a 
…) (#6081)

* Place: Made location @Embedded

* Nearby: Move handling map scroll to presenter

* PlacesRepository: Add methods for fetching places in geo bounds

* Nearby: add getScreenTopRight/BottomLeft and refactor old code

* PlacesRepository: Add methods for fetching places in map bounds

* Nearby: Complete offline pins implementation

* Nearby offline pins: Add snackbar message

* Nearby offline pins: Add javadoc

---------

Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@savsch savsch

Labels
enhancement nearby
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Nearby: show cached pins even when internet is unavailable (fixes #6051) savsch/apps-android-commons
2 participants
@nicolas-raoul @savsch