Skip to content

Use vector icons for nearby-map markers #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tobias47n9e opened this issue May 18, 2017 · 9 comments
Closed

Use vector icons for nearby-map markers #621

tobias47n9e opened this issue May 18, 2017 · 9 comments

Comments

@tobias47n9e
Copy link
Member

tobias47n9e commented May 18, 2017

Icon is currently a raster image, which can look blurry on phones with a high pixel density. Is it possible to replace it with an SVG icon?

screenshot_20170715-093544

@gupta-meghna64
Copy link
Contributor

image
@tobias47n9e Is this vector image fine instead of the raster image that is currently being used for nearby-map markers ?
If so, can I work on this issue ?

@misaochan
Copy link
Member

@gupta-meghna64 I can't answer your image question, will have to wait for @tobias47n9e or @neslihanturan for that. But absolutely, feel free to work on any issue here at all, and let us know if you need any help. :)

@neslihanturan
Copy link
Collaborator

Hi @gupta-meghna64 , thanks for your interest. I think we should definitely use vectors in our app. But it can be better if you can colourise the icon to our application blue.

Plus, the file is a .png export, however it is suppose to be a .svg file to solve the problem. Otherwise same thing would happen again. Or, we can use .xml files with tags also.

I use inkscape software (free softwre) for vector editing if you need to find such software to change the colour. Please let us know for further questions:)

akaita added a commit to akaita/apps-android-commons that referenced this issue Jul 15, 2017
@akaita
Copy link
Contributor

akaita commented Jul 15, 2017

Hi guys, I thought I could help out with the project so I completed the task and created #775 .
I hope that is fine :)

akaita added a commit to akaita/apps-android-commons that referenced this issue Jul 15, 2017
@tobias47n9e
Copy link
Member Author

Sorry missed the ping. I think black is fine for the icon if we can change the color in the code? That way we only need 1 SVG for day and night theme.

@tobias47n9e
Copy link
Member Author

Although this issue can be about all the icons in the app, I added a screenshot of the main icon this task is about. Compared to the other mapbox GL map-features it is very pixelated on my phone.

@akaita
Copy link
Contributor

akaita commented Jul 15, 2017

Oh 💡, I see I misunderstood which icon you were referring to...
Indeed, the one you refer to looks way worse (for some reason, there is only a mdpi version of it).

We will need a different svg for this one, mostly because of the shadow.
I'll check the best way to get this one done.

I will leave the #775 open, as it also seems to be relevant.

@akaita
Copy link
Contributor

akaita commented Jul 16, 2017

Created new PR with the proper change :)

@whym
Copy link
Collaborator

whym commented Jul 22, 2017

closed via #786

@whym whym closed this as completed Jul 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants