-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Use vector icons for nearby-map markers #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
|
@gupta-meghna64 I can't answer your image question, will have to wait for @tobias47n9e or @neslihanturan for that. But absolutely, feel free to work on any issue here at all, and let us know if you need any help. :) |
Hi @gupta-meghna64 , thanks for your interest. I think we should definitely use vectors in our app. But it can be better if you can colourise the icon to our application blue. Plus, the file is a .png export, however it is suppose to be a .svg file to solve the problem. Otherwise same thing would happen again. Or, we can use .xml files with tags also. I use inkscape software (free softwre) for vector editing if you need to find such software to change the colour. Please let us know for further questions:) |
Hi guys, I thought I could help out with the project so I completed the task and created #775 . |
Sorry missed the ping. I think black is fine for the icon if we can change the color in the code? That way we only need 1 SVG for day and night theme. |
Although this issue can be about all the icons in the app, I added a screenshot of the main icon this task is about. Compared to the other mapbox GL map-features it is very pixelated on my phone. |
Oh 💡, I see I misunderstood which icon you were referring to... We will need a different svg for this one, mostly because of the shadow. I will leave the #775 open, as it also seems to be relevant. |
Created new PR with the proper change :) |
closed via #786 |
Icon is currently a raster image, which can look blurry on phones with a high pixel density. Is it possible to replace it with an SVG icon?
The text was updated successfully, but these errors were encountered: