Crash when gallery image is shared with the Commons app #668

nicolas-raoul · 2017-05-21T11:46:47Z

From the stock gallery I shared to Commons.
The image loaded fullscreen, but surprisingly the UI did not load anything else.
Killing Commons by swiping it was not enough to fix the problem, I had to force-stop it in Settings→Apps

misaochan · 2017-05-23T15:35:38Z

@nicolas-raoul does this happen all the time for you, or just once?

Sorry, I am going to be in a plane most of tomorrow so can't check it :(

nicolas-raoul · 2017-05-23T15:43:52Z

It happened 3 times, among 26 uploads.

…

On 24 May 2017 00:35, "Josephine Lim" ***@***.***> wrote: @nicolas-raoul <https://github.com/nicolas-raoul> does this happen all the time for you, or just once? Sorry, I am going to be in a plane most of tomorrow so can't check it :( — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#668 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGFBm7s2_amRLF0BjaEs4NqyMjWa5Gbks5r8vzLgaJpZM4Nhkxu> .

misaochan · 2017-05-23T18:48:54Z

Wow, that is pretty bad.

Do you guys think we should revert to the last stable version for production (2.2.2)? It will be missing all the improvements we made over the weekend but it might be needed if lots of people aren't able to upload. Please help test if you can and provide feedback.

@nicolas-raoul do you think you could do the revert for production if needed? I will be flying/ transiting till Thursday so I may not be able to access the internet. I'm in Zurich airport now, leaving soon.

We can probably leave the beta on 2.4 since anyone who really needs to will be able to drop out of beta.

Thanks!

VojtechDostal · 2017-05-23T19:03:42Z

This just happened to me too. There was an android update in the morning, or maybe just Google Play's update. Whatever it was, I couldnt open the Commons app today (it said: "app not installed"). So I uninstalled and installed the app again, it now works, but when I choose a picture to upload it just shows on full-screen. When I try to do this repeatedly, or try to click here an there, it often causes the app to crash.

I don't mind keeping it in beta, as soon as we will work on this in a matter of days/few weeks max. If it takes more then let's revert to the stable version.

tobias47n9e · 2017-05-23T21:04:02Z

Couldn't reproduce the issue today trying a few different Android versions in the emulator. Anyone have steps that always lead to the issue?

nicolas-raoul · 2017-05-24T03:25:04Z

@VojtechDostal Would you mind repeating the full-screen bug while taking the log with adb logcat, and sending us the log? Thanks a lot!
Same for the crashes if possible, as a new issue :-)

VojtechDostal · 2017-05-24T08:56:08Z

OK, will do but not before today evening. Which category of logs in Android Studio do you want me to send? I can choose several options from the rollup. thanks

nicolas-raoul · 2017-05-24T09:31:15Z

Everything? :-) If it is too big you can post to pastebin.

…

On Wed, May 24, 2017 at 5:56 PM, VojtechDostal ***@***.***> wrote: OK, will do but not before today evening. Which category of logs in Android Studio do you want me to send? I can choose several options from the rollup. thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#668 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGFBtAX9_aKSoCfCCvfyqGmeOic3xPEks5r8_CpgaJpZM4Nhkxu> .

misaochan · 2017-05-25T02:26:25Z

I reverted production to the latest stable version (2.2.2). Left 2.4 in beta, so those who aren't having issues or want to test the new features can remain in 2.4, while those who are having issues can opt out of beta for the time being.

Hopefully we'll find a fix for 2.4 soon.

VojtechDostal · 2017-05-25T06:41:00Z

I cannot reproduce the problem I had yesterday. I will keep trying.

misaochan · 2017-05-26T10:56:04Z

@nicolas-raoul Are you able to reproduce the issue with 2.4? If you are, could you post the logs? Thanks!

misaochan · 2017-05-26T10:57:04Z

There is a crash report, not sure if it's the same bug:

USER_COMMENT=Tried to share two pictures with the Wikimedia Commons app
ANDROID_VERSION=7.1.1
APP_VERSION_NAME=2.4
BRAND=OnePlus
PHONE_MODEL=ONEPLUS A3003
CUSTOM_DATA=
STACK_TRACE=java.lang.ClassCastException: com.facebook.drawee.view.SimpleDraweeView cannot be cast to fr.free.nrw.commons.MediaWikiImageView
at fr.free.nrw.commons.upload.MultipleUploadListFragment$PhotoDisplayAdapter.getView(MultipleUploadListFragment.java:82)
at android.widget.AbsListView.obtainView(AbsListView.java:2379)
at android.widget.GridView.onMeasure(GridView.java:1065)
at android.view.View.measure(View.java:19955)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6087)
at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1464)
at android.widget.LinearLayout.measureVertical(LinearLayout.java:758)
at android.widget.LinearLayout.onMeasure(LinearLayout.java:640)
at android.view.View.measure(View.java:19955)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6087)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:185)
at android.view.View.measure(View.java:19955)
at android.widget.RelativeLayout.measureChildHorizontal(RelativeLayout.java:715)
at android.widget.RelativeLayout.onMeasure(RelativeLayout.java:461)
at android.view.View.measure(View.java:19955)
at android.support.v4.widget.DrawerLayout.onMeasure(DrawerLayout.java:1081)
at android.view.View.measure(View.java:19955)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6087)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:185)
at android.support.v7.widget.ContentFrameLayout.onMeasure(ContentFrameLayout.java:139)
at android.view.View.measure(View.java:19955)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6087)
at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1464)
at android.widget.LinearLayout.measureVertical(LinearLayout.java:758)
at android.widget.LinearLayout.onMeasure(LinearLayout.java:640)
at android.view.View.measure(View.java:19955)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6087)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:185)
at android.view.View.measure(View.java:19955)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6087)
at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1464)
at android.widget.LinearLayout.measureVertical(LinearLayout.java:758)
at android.widget.LinearLayout.onMeasure(LinearLayout.java:640)
at android.view.View.measure(View.java:19955)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6087)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:185)
at com.android.internal.policy.DecorView.onMeasure(DecorView.java:689)
at android.view.View.measure(View.java:19955)
at android.view.ViewRootImpl.performMeasure(ViewRootImpl.java:2309)
at android.view.ViewRootImpl.measureHierarchy(ViewRootImpl.java:1392)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1645)
at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1280)
at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6432)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:874)
at android.view.Choreographer.doCallbacks(Choreographer.java:686)
at android.view.Choreographer.doFrame(Choreographer.java:621)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:860)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6290)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

nicolas-raoul · 2017-05-26T10:59:18Z

Sorry I haven't had time to try (_ _)

…

On 26 May 2017 7:56 p.m., "Josephine Lim" ***@***.***> wrote: @nicolas-raoul <https://github.com/nicolas-raoul> Are you able to reproduce the issue with 2.4? If you are, could you post the logs? Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#668 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGFBk5jciabbKgECXW2_7izBPxOkBghks5r9q_EgaJpZM4Nhkxu> .

misaochan · 2017-05-26T14:25:42Z

Got 2 more crash reports similar to the one above. I think that is quite clearly the source of the issue, or at least one of the sources.

misaochan · 2017-05-26T14:27:23Z

Oh, @dbrant , I think that portion of MultipleUploadListFragment.java was part of your patch, haha. :) Any idea what could've broken it?

dbrant · 2017-05-26T14:49:40Z

D'oh! Will look into it asap.

dbrant · 2017-05-26T17:44:26Z

Should be fixed via #681.

misaochan · 2017-05-27T06:47:17Z

Thanks @dbrant ! Will push to beta ASAP. In the meantime, if anyone could help test the current master branch and see if it's still crashing for them, that would be a huge help. :)

misaochan · 2017-05-27T14:49:02Z

v 2.4.1 pushed to beta, if anyone is still having issues with this crash please let us know.

misaochan · 2017-05-30T06:25:31Z

Anyone? Will close issue otherwise.

VojtechDostal · 2017-05-30T09:24:40Z

No problem here.

tobias47n9e · 2017-05-30T10:06:08Z

It works for me. A seperate issue to implement some upload tests would be a good idea though. We should never accidentally break our main features.

misaochan · 2017-05-30T10:21:42Z

@tobias47n9e : Agreed, sounds like a good idea to me

nicolas-raoul added bug metadata labels May 21, 2017

tobias47n9e changed the title ~~Title/description fields do not appear, just the image fullscreen~~ Crash when gallery image is shared with the Commons app May 23, 2017

misaochan mentioned this issue May 28, 2017

Urgent issues that should ideally be fixed before final publicity step #693

Closed

6 tasks

misaochan closed this as completed May 30, 2017

Crash when gallery image is shared with the Commons app #668

Crash when gallery image is shared with the Commons app #668

Comments

nicolas-raoul commented May 21, 2017

misaochan commented May 23, 2017

Uh oh!

nicolas-raoul commented May 23, 2017 via email

Uh oh!

misaochan commented May 23, 2017

Uh oh!

VojtechDostal commented May 23, 2017

Uh oh!

tobias47n9e commented May 23, 2017

Uh oh!

nicolas-raoul commented May 24, 2017

Uh oh!

VojtechDostal commented May 24, 2017

Uh oh!

nicolas-raoul commented May 24, 2017 via email

Uh oh!

misaochan commented May 25, 2017

Uh oh!

VojtechDostal commented May 25, 2017

Uh oh!

misaochan commented May 26, 2017

Uh oh!

misaochan commented May 26, 2017

Uh oh!

nicolas-raoul commented May 26, 2017 via email

Uh oh!

misaochan commented May 26, 2017

Uh oh!

misaochan commented May 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dbrant commented May 26, 2017

Uh oh!

dbrant commented May 26, 2017

Uh oh!

misaochan commented May 27, 2017

Uh oh!

misaochan commented May 27, 2017

Uh oh!

misaochan commented May 30, 2017

Uh oh!

VojtechDostal commented May 30, 2017

Uh oh!

tobias47n9e commented May 30, 2017

Uh oh!

misaochan commented May 30, 2017

Uh oh!

misaochan commented May 26, 2017 •

edited

Loading