-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add limited connection mode #746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think Nearby takes a very small amount of bandwidth currently. But you have a point re: contributions (although AFAIK uploading in and of itself takes a whole lot more bandwidth due to the image being full-size, compared to thumbnails for contributions). But, I'm good with this if there is a need for it, at any rate it couldn't hurt. :) |
I think that our current traffic map also needs to get traffic information in addition to the map tiles. Not sure what impact that has. I think Commons uploads and downloads fall under Wikipedia Zero in participating countries. Is there a low bandwidth map we can load from mapbox? |
Image upload is clearly the biggest data plan eater. So I think a "low-bandwidth mode" should:
|
Upload picture later option is a great idea. We can even create a queue of pictures. Mapbox supports offline maps if user has selected the area. Plus, I think we need to change our traffic map to pedestrian map in any case. |
Yes, it would be great to implement the offline support(upload later). I would be able to help with the flow and sync logic having done it for offline payments. :) |
Sounds good to me. :) Do you guys think it is sufficiently important/easy that we should add it to the renewal proposal? Or if it's not easy, do you think it's sufficiently important that we should remove something else to make way for this? |
Hard question. I don't think it is easy, however in my point of view it is quite important. |
I agree with @neslihanturan. Its important as in my opinion the feature to queue up pictures for upload and not waiting for the upload to complete could highly motivate users to upload more pictures |
@maskaravivek I think our app already queues up pictures for upload, you can upload as many as you want without waiting for the previous uploads to complete. But waiting for WiFi could definitely help in a situation where the user has limited mobile data, then he can queue the uploads for later instead of having to remember to do it later. |
Do you think it is easy to implement this feature? |
I believe I made a bad assumption about how multiple share works in those mockups - looking through the code I see that although I might share 5 images in a single "batch" and they land in the database with a flag saying |
Jun 12, 2017 Google Play review:
|
@psh 's mockups for the upload queue look great to me. :)
I've been thinking about this, and it would be very useful indeed if we could allow the upload to be done in chunks, so that it can be paused and resumed (and also users don't lose upload progress if their internet is spotty). I am sure it CAN be done as other apps have done it, but I'm not sure how time-consuming or involved the implementation would be. @maskaravivek @psh or anyone else, any thoughts on this? I would like to add this to our plans for next year, if it is feasible. :) |
I would love to have the feature of pausing and resuming the |
Also, it would be nice if the app automatically detects a slow internet connection and switches to the limited connection mode without the user having to turn it on. And yes, the user should be allowed to turn it off if he wants to. |
Thanks for the feedback @sivaraam , happy to hear that the feature will be useful for you. :) I am not so sure about automatically detecting a slow internet connection - what would we define as "slow"? What if the user doesn't actually want to turn on limited connectivity, but stubbornly wants to browse pictures even if his home connection is slow? He may be annoyed at having to keep turning it off. |
I'm not sure about the feature too but just some random thoughts.
Some time period within which you expect the response to have come but it hasn't?
Yeah, some features sometimes turn out to have bad consequences for a few people. I guess we could play safe by not trying to detect slow networks for the session (until app is killed) if the user turns off when we detect slow network. Also, making it customizable might also help. I'm not going to advocate this feature a lot. Just writing out some of my thoughts about it. |
For slow network discussion: We plan to have a limited connection mode toggle on the action bar as mentioned in #2843 . A user may want to use the app in normal mode in general (ie. using the map) but just want to wait for Wifi for uploads. Or they may want to use their connection for upload, but not for the map. For this possibility I think we can have an additional toggle as upload when wifi detected on upload steps. Ie: If the global "limited connection toggle" is activated, then the default value for this button should be on. |
Great idea IMO! I am all for it. :) |
Hi team, for upload queue UI, I loved the designs proposed by @psh : But they are not very similar with our existing constibutions list style: So here is my question, should I keep the current list design and create something similar for upload queue, or should I redesign our contributions list in a similar way with @psh 's design? It can be good to note that we are planning to have a new overall design at the end of this year #2843 . In scope of this new design our MediaDetailsActivity will be redesigned in a similar style of our current 3 upload screens which are added by @maskaravivek . So we won't have a semi-transparent layer on MediaDetails anymore and it may be a good decision redesigning all semitransparent black components (see the layer for file names on the list). This means changing our current contributions (and explore) list style together with MediaDetailsActivity. |
I like the proposed designs, too. :) A few considerations:
|
Edit: see #2843 (comment) for more details. |
Note: When we do this we should also increase the timeout limit for network-based procedures (e.g. logging in). We currently seem to time out after about 10 seconds, based on my experience with the app when Commons was experiencing latency spikes. |
That looks nice. Just a suggestion. "(Uploading… 53% of image is uploaded)" seems too verbose and the brackets seem unnecessary. I believe "Uploading… 53%" would be concise and clear. Ditto for "Paused…". Additionally, I think it would be useful to show the size corresponding to the part of the image that's left to be uploaded. |
Yeah. As I said before, wouldn't it be a little too aggressive, to prevent the automatic download of thumbnails that populates the Contributions etc list? Wouldn't it significantly affect the usability the app when browsing images? |
I don't think so, as it is an option that the user can toggle on and off as they wish. Currently all users must load at least the first page of Contributions before they can even use the app. This way users who want to just, say, use Nearby to photograph a few pins while on limited data, won't have to waste their data on image downloads.
It will, but if we want maximum usability of all features all the time, there is no point to even implementing a limited connection mode, as limiting bandwidth usage is the very definition of the mode. If a user wants to browse images, they can turn limited connection mode off. |
Yeah, that certainly would be a solution. Anyways, I was thinking if it would be nice to have multiple levels in the limited connection modes:
I'm not sure if its worth it, though. |
Could be a future enhancement. ;) Let's implement the basic feature first and get user feedback? |
Sure. :) |
Here are the changes that I am making for the remaining pieces of this feature:
cc @misaochan |
So, "limited-connection" mode had turned to "offline" mode now. It's a little weird because I see our app's primary purpose as uploading images and then to browse them. So, a "Offline" mode sounds contradictory right in it's name. I didn't get this feeling for "limited-connection" mode. We should like think about the name 🤔
This sounds a little off to me. So if a user enables offline mode, they would have no way to add categories to the image they upload via the app? I wonder if that's going too much to conserve data as it's clearly curbing such users from a useful feature of the app. I would say it's better to allow users to add categories to the uploaded image regardless of the mode. Ditto for the image processing checks. I feel that there shouldn't be a problem with doing any check that does not upload the whole picture. I just don't get why we should skip significant /useful checks just because a user has limited data. For instance, wouldn't it be better if we do the "Image already present in Commons" check and warn the user before hand about that instead of skipping that check; allowing user to upload it; have that image possibly deleted as a duplicate later? Correct me if I got something wrong. |
@sivaraam Sorry, for the confusion. I have updated the scope based on your comment. |
Nice. I just have one doubt for now:
Does this apply only for mobile data or also for Wi-Fi? I'm mostly just trying to get a refined meaning for "online" here. My understanding is that this should happen only for mobile-data per #746 (comment):
|
For now, limited connection mode if enabled would be effective on any network the user might be using. In the future, we can have another set in the Settings page where he can define his preference. |
Makes sense to me @maskaravivek .
Hmm, good point @sivaraam . I should have defined that more clearly in the scope. At the moment it feels like adding Wi-Fi detection would be adding a lot of complexity to the implementation. After the basic feature is out, perhaps we can get feedback from users on their preference for whether or not they'd like network detection. |
Well, I could not find nice a CC0 placeholder file, so made one myself :). We can use this: https://commons.wikimedia.org/wiki/File:Placeholder_view_vector.svg |
Did anybody try uploading images with limited connections, like in #3972? |
Has there been any progress on this feature? |
@fnordson I have never tested it yet, but I believe it is now implemented on the master branch, which you can get by opting for the alpha version, instructions at https://github.com/commons-app/commons-app-documentation/blob/master/android/Volunteers-welcome!.md#how-to-install-the-alpha Thanks! |
I've successfully signed up yesterday but I didn't get the Alpha. Still on 2.13.2. |
Hi @fnordson , what email address did you sign up to the alpha google group with? |
@fnordson Can you please post a screenshot of your About screen? The commit number might reveal something. |
@misaochan you should have got it if you have notifications on. |
@fnordson Does Play Store show the app as up-to-date? And if yes, would you mind trying to uninstall and reinstall? Sorry for the inconvenience! |
@nicolas-raoul No problem. I did uninstall it twice now. Once a few hours after I joined the alpha programme and a second time minutes ago. (Other apps did update in that time so it's not my store or something like that) |
@fnordson , I did not receive a notification, hence why I am asking for the email address that you signed up with, so that I can check if you are actually a member of the group (which is required for alpha testing). If you don't wish to reveal it here, please email commons-app-android-private@googlegroups.com so that we can look into it. Alpha testing is a subset of beta testing. To be an alpha tester you have to be signed up for beta testing on Google Play, and also a member of https://groups.google.com/d/forum/commons-alpha |
@misaochan I seems my join to the group had been blocked by my adblocker. I'm in now...sorry for the confusion :( |
Happy to hear that @fnordson :) |
I think most of our users might be travelling abroad and they possibly have limited internet connection. They should be able to select "limited connection mode" to prevent contribution and nearby lists from load (we can display an information string instead). So user can only upload image by using minimal amount of resources. Do you also think such feature would be nice?
The text was updated successfully, but these errors were encountered: