-
Notifications
You must be signed in to change notification settings - Fork 1.3k
If a category has exact name entered, show it first #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Agreed, that would be good! |
You could design the search method to check for similarities ignoring caps, then by simple calculation decide if by how much percentage the query matches a category. Then sort the results from highest match to lowest. |
@ismailisimba Something similar has already been implemented by @misaochan, please see https://github.com/commons-app/apps-android-commons/wiki/Category-suggestions-%28readme%29 |
Is the issue still open? if yes, can i work on it ? |
@Kartik2016 Please feel free, thanks! :) |
If @Kartik2016 doesn't work on this issue, I'd like to fix this :) |
Oh, sorry for not assigning this one in time... |
Hum, looks like Github does not allow me to assign to anybody outside the organization, actually! |
Yeah, the assignment is messy. :/ Maybe we could just state in comments "assigned to [name]", along with adding that label? |
Fixing #844 - If a category has exact name entered, show it first
@nicolas-raoul This is strangely weird. I tried with exactly the ones you tried, and they're appearing at the top of list for me :-/ |
@gupta-meghna64 I am using the Play Store beta version, I guess this has been fixed in master? :-) |
Yes @nicolas-raoul :) |
WIth the latest Git, yesterday I got this situation: I typed the name of a category that I know exists, but I had a hard time finding it, because it was far down in the suggestions.
My suggestion: If a category has exact name entered (ignoring uppercase/lowercase), show it first
The text was updated successfully, but these errors were encountered: