Skip to content

If a category has exact name entered, show it first #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicolas-raoul opened this issue Aug 14, 2017 · 14 comments
Open

If a category has exact name entered, show it first #844

nicolas-raoul opened this issue Aug 14, 2017 · 14 comments

Comments

@nicolas-raoul
Copy link
Member

WIth the latest Git, yesterday I got this situation: I typed the name of a category that I know exists, but I had a hard time finding it, because it was far down in the suggestions.

My suggestion: If a category has exact name entered (ignoring uppercase/lowercase), show it first

@misaochan
Copy link
Member

Agreed, that would be good!

@ismailisimba
Copy link

You could design the search method to check for similarities ignoring caps, then by simple calculation decide if by how much percentage the query matches a category. Then sort the results from highest match to lowest.

@nicolas-raoul
Copy link
Member Author

@ismailisimba Something similar has already been implemented by @misaochan, please see https://github.com/commons-app/apps-android-commons/wiki/Category-suggestions-%28readme%29
Cheers!

@Kartikdot
Copy link

Is the issue still open? if yes, can i work on it ?

@misaochan
Copy link
Member

@Kartik2016 Please feel free, thanks! :)

@pszklarska
Copy link

If @Kartik2016 doesn't work on this issue, I'd like to fix this :)

@nicolas-raoul
Copy link
Member Author

Oh, sorry for not assigning this one in time...
It seems that both @Kartik2016 and @pszklarska started working on it at the same time. Apologies for the confusion, this time I guess it makes sense to assign it to @pszklarska who has sent a pull request already. In the future we will try to assign sooner!

@nicolas-raoul
Copy link
Member Author

Hum, looks like Github does not allow me to assign to anybody outside the organization, actually!
This means we need another way to indicate that an issue is assigned... maybe a label?
In any case we will need to make that explicit in the documentation.

@misaochan
Copy link
Member

Yeah, the assignment is messy. :/ Maybe we could just state in comments "assigned to [name]", along with adding that label?

nicolas-raoul added a commit that referenced this issue Oct 2, 2017
Fixing #844 - If a category has exact name entered, show it first
@nicolas-raoul
Copy link
Member Author

nicolas-raoul commented Feb 27, 2018

Strangely I still see this problem recently, the category with the entered name is very far in the list of suggestions:
screenshot_20180122-143127
screenshot_20180125-144542
screenshot_20180125-144605

@gupta-meghna64
Copy link
Contributor

@nicolas-raoul This is strangely weird. I tried with exactly the ones you tried, and they're appearing at the top of list for me :-/

@nicolas-raoul
Copy link
Member Author

nicolas-raoul commented Mar 22, 2018

@gupta-meghna64 I am using the Play Store beta version, I guess this has been fixed in master? :-)

@gupta-meghna64
Copy link
Contributor

Yes @nicolas-raoul :)

@nicolas-raoul
Copy link
Member Author

Happening currently in 2.8-release branch:
screenshot_20180720-004644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants