Skip to content

Conversation

@Clockery
Copy link

No description provided.

@nicolas-raoul nicolas-raoul merged commit 635e3d3 into commons-app:master Dec 14, 2017
@nicolas-raoul
Copy link
Member

Thanks! You are from Code-in I guess?

@Clockery
Copy link
Author

Yeah, I am :) I didn't realise the pull request had been sent, my net was down for a while! Thanks a lot :)

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Dec 14, 2017 via email

@Clockery
Copy link
Author

Sure, but wait, this is all that has to be done for the task?

@Clockery
Copy link
Author

I've submitted the task for review, but shouldn't the files be translated on TWN? How is that done?

@nicolas-raoul
Copy link
Member

Oh yes indeed, I forgot that was only the first step!
Sorry about my mistake ('-_-)

For Translatewiki, if you identify what setting files need to be changed how, that's good enough.
First, please find our current translatewiki configuration file, where these files are referenced: https://github.com/commons-app/apps-android-commons/tree/master/app/src/main/res/values

@nicolas-raoul
Copy link
Member

Let's continue the conversation at #790

@Clockery
Copy link
Author

Sure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants