Conversation
| <fr.free.nrw.commons.ui.widget.HtmlTextView | ||
| android:id="@+id/reset_password_link" | ||
| style="?android:textAppearanceSmall" | ||
| android:layout_width="wrap_content" |
There was a problem hiding this comment.
This should be "0dp" to make "layout_weight=1" work.
| <fr.free.nrw.commons.ui.widget.HtmlTextView | ||
| android:id="@+id/about_privacy_policy" | ||
| style="?android:textAppearanceSmall" | ||
| android:layout_width="wrap_content" |
There was a problem hiding this comment.
This should be "0dp" to make "layout_weight=1" work.
| style="?android:textAppearanceSmall" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_weight="1" |
There was a problem hiding this comment.
You should add android:gravity="center_horizontal" line to make texts centered.
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginLeft="@dimen/large_gap" | ||
| android:layout_weight="1" |
There was a problem hiding this comment.
You should add android:gravity="center_horizontal" line to make texts centered.
|
Thanks @Mustahai for the PR:). It works but doesn't look very symmetric currently. So, some changes requested. Our expectation from your fixes is:
|
|
Thank you @neslihanturan for your feedback. I have updated and commited changes according to your feedback. I hope they will be according to your expectations. |
Codecov Report
@@ Coverage Diff @@
## master #1077 +/- ##
======================================
Coverage 3.85% 3.85%
======================================
Files 125 125
Lines 5757 5757
Branches 567 567
======================================
Hits 222 222
Misses 5520 5520
Partials 15 15Continue to review full report at Codecov.
|
|
Just curious why the mockup in the original issue wasn't implemented -
|
|
Oh, I wasn't aware of that design @psh , so tried make it better on my previous comments. But IMO the design you shared looks better. Sorry for missing that :/ |
|
So I've been working on changing the design to fit @psh 's mockup, and unfortunately I've run into two issues that I hope you will be able to help me solve. This is the current layout on my emulator:
Now my issues are the following:
I hope to solve both issues with your sugestions. |
|
@Mustahai , can you please commit your code that results as you shared? So that we can see whats going on. |
|
The main issue I'm struggling with is that the login activity is a scroll view, so I can't, as far as I know, just send the policy settings link to the bottom of the screen. |
|
Have fixed the merge conflicts. Will merge once the checks pass. |
|
Thanks for fixing the conflicts @maskaravivek , but according to discussion above, I have some doubts to merge this as is. What do you suggest @psh , should we wait for updates or merge it as is, since it doesn't look very problematic currently. |
|
How does the UI look currently? Does it still have the overlapping text that is shown in the most recent screenshot? |
|
@maskaravivek I think the issue is already fixed. So we can close this PR. |
Fix for Issue #1063 "Forgot password" link on login screen