Skip to content

Fix for issue #1157 Added try-catch block in getBuildVersion function in gitutils.gradle … #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 3, 2019

Conversation

csk1827
Copy link
Contributor

@csk1827 csk1827 commented Feb 16, 2018

…file.

@codecov-io
Copy link

codecov-io commented Feb 16, 2018

Codecov Report

Merging #1158 into master will increase coverage by 2.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1158      +/-   ##
=========================================
+ Coverage    3.98%   6.35%   +2.36%     
=========================================
  Files         123     233     +110     
  Lines        5572   11573    +6001     
  Branches      537    1066     +529     
=========================================
+ Hits          222     735     +513     
- Misses       5335   10776    +5441     
- Partials       15      62      +47
Impacted Files Coverage Δ
.../free/nrw/commons/di/CommonsApplicationModule.java 27.5% <0%> (-25.14%) ⬇️
app/src/main/java/fr/free/nrw/commons/Utils.java 24.39% <0%> (-10.5%) ⬇️
...in/java/fr/free/nrw/commons/data/DBOpenHelper.java 12.5% <0%> (-7.5%) ⬇️
...rw/commons/mwapi/ApacheHttpClientMediaWikiApi.java 3.93% <0%> (-1.88%) ⬇️
...main/java/fr/free/nrw/commons/location/LatLng.java 52.77% <0%> (-1.51%) ⬇️
.../java/fr/free/nrw/commons/auth/SessionManager.java 16.17% <0%> (-0.97%) ⬇️
...n/java/fr/free/nrw/commons/MediaDataExtractor.java 0% <0%> (ø) ⬆️
...n/java/fr/free/nrw/commons/auth/LoginActivity.java 0% <0%> (ø) ⬆️
...mmons/contributions/ContributionsListFragment.java 0% <0%> (ø) ⬆️
...ree/nrw/commons/auth/WikiAccountAuthenticator.java 0% <0%> (ø) ⬆️
... and 192 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ce394...728922b. Read the comment docs.

@neslihanturan
Copy link
Collaborator

Hmm, there is nothing stops me to merge this PR. However, discussion still continues at #1157. Better to wait for a conclusion.

@misaochan misaochan reopened this Jan 3, 2019
@misaochan
Copy link
Member

Reopening this as per discussion with @maskaravivek about #1157 . Fixed formatting and added explanatory comment.

@misaochan misaochan requested a review from maskaravivek January 3, 2019 14:45
@maskaravivek maskaravivek merged commit 7b2f719 into commons-app:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants