Fix issue #1030: Spinning wheel overlaps on text input, when using Hebrew locale #1162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1162 +/- ##
======================================
Coverage 3.81% 3.81%
======================================
Files 125 125
Lines 5815 5815
Branches 568 568
======================================
Hits 222 222
Misses 5578 5578
Partials 15 15Continue to review full report at Codecov.
|
|
I will test it whenever #1163 is solved. |
…commons into category-alignment
| android:visibility="gone" /> | ||
| android:layout_marginRight="@dimen/tiny_gap" | ||
| android:layout_marginEnd="@dimen/tiny_gap" | ||
| android:layout_gravity="center_vertical|right" |
There was a problem hiding this comment.
It seems like the only change is this line. But places of other lines are changed. I couldn't understand the reason of this changes. No block for merge anyway, just noted to consider on future PRs:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue arises for any locale which uses language read from right to left.
Since category search is implemented only in English, it is expected that the user will use English in category search. Hence, to fix this, I changed the editText gravity to the left and the progressBar gravity to the right, instead of letting it adapt to the locale as Android's default behaviour allows.