Skip to content

Conversation

@gupta-meghna64
Copy link
Contributor

@gupta-meghna64 gupta-meghna64 commented Feb 18, 2018

Hey!
To enhance the user experience, the soft keyboard is now being hidden whenever the EditText loses focus. The changes have been made to the following:

  1. acitivity_login
  2. fragment_categorization
  3. fragment_multiple_upload_lists

This PR references the issue #1109
Edit: I've added a new PR as a few issues were coming up with the previous one.
Please review :-)
Thanks!

@codecov-io
Copy link

Codecov Report

Merging #1168 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1168      +/-   ##
=========================================
- Coverage    3.85%   3.83%   -0.03%     
=========================================
  Files         125     125              
  Lines        5757    5793      +36     
  Branches      567     568       +1     
=========================================
  Hits          222     222              
- Misses       5520    5556      +36     
  Partials       15      15
Impacted Files Coverage Δ
...e/nrw/commons/category/CategorizationFragment.java 0% <0%> (ø) ⬆️
...n/java/fr/free/nrw/commons/auth/LoginActivity.java 0% <0%> (ø) ⬆️
...nrw/commons/upload/MultipleUploadListFragment.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 054fa93...a2598d1. Read the comment docs.

@gupta-meghna64
Copy link
Contributor Author

It'd be great if someone could review this PR :-)

@misaochan
Copy link
Member

Hi @gupta-meghna64 , sorry, there is a bit of a backlog going on, and we generally have to take some time to test every PR before we merge it. Please feel free to work on other issues in the meantime, if you would like. :)

@maskaravivek
Copy link
Contributor

Looks good to me. Have also tested it on a real device and it works perfectly for me. Going ahead and merging this.

@gupta-meghna64 Congrats for your first contribution. :)

@maskaravivek maskaravivek merged commit 9aceaca into commons-app:master Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants