Skip to content

Fix order of notifications #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2018

Conversation

maskaravivek
Copy link
Member

Description

Part of fixes for #7. Now the newest notification is on the top.

Screenshots showing what changed

Before

notification_order_before

After

notifications_order_after

@codecov-io
Copy link

Codecov Report

Merging #1184 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1184      +/-   ##
=========================================
- Coverage    3.82%   3.82%   -0.01%     
=========================================
  Files         125     125              
  Lines        5798    5799       +1     
  Branches      568     568              
=========================================
  Hits          222     222              
- Misses       5561    5562       +1     
  Partials       15      15
Impacted Files Coverage Δ
...nrw/commons/notification/NotificationActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a2b51...3045b63. Read the comment docs.

@misaochan misaochan merged commit 12b852f into commons-app:master Feb 25, 2018
@maskaravivek maskaravivek deleted the notificationOrder branch September 12, 2018 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants