Rate Us feature added

[ujjwalagrawal17]

Description

Fixes #1187

1. Added star icon in drawable and string in drawer.xml
2. Redirect to google play store in NavigationBaseActivity using

final String appPackageName = getPackageName();
try {
startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse("market://details?id=" + appPackageName)));
}
catch (android.content.ActivityNotFoundException anfe) {
startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse("https://play.google.com/store/apps/details?id=" + appPackageName)));
}

Screenshots showing what changed

[codecov-io]

Codecov Report

Merging #1188 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1188      +/-   ##
=========================================
- Coverage    3.81%   3.81%   -0.01%     
=========================================
  Files         125     125              
  Lines        5812    5821       +9     
  Branches      568     568              
=========================================
  Hits          222     222              
- Misses       5575    5584       +9     
  Partials       15      15

Impacted Files	Coverage Δ
...free/nrw/commons/theme/NavigationBaseActivity.java	22.72% <ø> (ø)	⬆️
...c/main/java/fr/free/nrw/commons/AboutActivity.java	0% <ø> (ø)	⬆️
app/src/main/java/fr/free/nrw/commons/Utils.java	26.31% <0%> (-3.1%)	⬇️
...fr/free/nrw/commons/media/MediaDetailFragment.java	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1db1715...6277272. Read the comment docs.

[maskaravivek]

Toast not needed

[ujjwalagrawal17]

It was for testing, I will remove it.

[maskaravivek]

I would suggest extracting the rate us option logic to a different class(probably Utils). Later on we can have this option plugged in at multiple locations.

[ujjwalagrawal17]

Ok I will add a method in Utils.java.

[maskaravivek]

@ujjwalagrawal17 based on the discussion in #1187 can you make the changes and put the Rate us feature in the About page instead. :)

Sorry, to make you redo the work.

[ujjwalagrawal17]

@maskaravivek I had shifted rate us feature from nav drawer to about page.

Here is the new UI of about page.

[nicolas-raoul]

I suggest making it "Rate us" to be case-coherent with the next line.
Otherwise looks good to me :-)

[maskaravivek]

Thanks for making the changes @ujjwalagrawal17. Can you resolve the merge conflicts too. :)

[ujjwalagrawal17]

@maskaravivek How to resolve Travis-ci build failed issue ?

[maskaravivek]

@ujjwalagrawal17 I guess this error is coming after resolving merge conflicts. You would have incorrectly resolved the errors. :)

The travis shows the following error. Please check the xml file.

/home/travis/build/commons-app/apps-android-commons/app/build/intermediates/res/merged/beta/debug/layout/activity_about.xml:172: error: Error parsing XML: mismatched tag

[neslihanturan]

Thanks @ujjwalagrawal17 !