Fixes #1207 #1208
Merged
Fixes #1207 #1208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1208 +/- ##
======================================
Coverage 3.82% 3.82%
======================================
Files 125 125
Lines 5810 5810
Branches 568 568
======================================
Hits 222 222
Misses 5573 5573
Partials 15 15Continue to review full report at Codecov.
|
Contributor
|
The PR fixes the crash. Tested on a real device. Going ahead and merging it. Thanks for your contribution @knight-shade. Keep up the good work! :) |
Contributor
Author
|
Thank you very much @maskaravivek, glad to contribute. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1207
login_credentials textview added to landscape and x-large activity_login.xml
Screenshots showing what changed