Skip to content

Conversation

@gupta-meghna64
Copy link
Contributor

@gupta-meghna64 gupta-meghna64 commented Feb 26, 2018

Description

This formats the text properly in all the tutorial layout pages, which enhance the UI of the application.
The PR fixes #1196

Changes Made

Instead of a '-', bullet points were used. New line spaces were properly indented after the bullet marks.
The changes were made to the following xml pages:

  1. welcome_do_upload.xml(2)
  2. welcome_dont_upload.xml(2)
  3. welcome_image_details.xml(2)

Screenshots of sample changes

This is one of the changes

Before

whatsapp_image_2018-02-25_at_12 38 44_pm_ 1 2

After

whatsapp_image_2018-02-25_at_12 38 44_pm 2
whatsapp_image_2018-02-26_at_9 38 18_am
whatsapp_image_2018-02-26_at_9 38 18_am_ 1

Device and Android Version

Redmi Note 3 and 6.0.1 MB29M

@codecov-io
Copy link

Codecov Report

Merging #1210 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1210   +/-   ##
======================================
  Coverage    3.82%   3.82%           
======================================
  Files         125     125           
  Lines        5810    5810           
  Branches      568     568           
======================================
  Hits          222     222           
  Misses       5573    5573           
  Partials       15      15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215c97e...68ac0db. Read the comment docs.

@maskaravivek
Copy link
Contributor

maskaravivek commented Feb 26, 2018

@gupta-meghna64 I am not able to view the screenshots. Can you check if they were properly uploaded.

@gupta-meghna64
Copy link
Contributor Author

Sorry for that. I've updated the links. Please review :-)

Copy link
Contributor

@maskaravivek maskaravivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a real device. Works perfectly. Thanks for the PR @gupta-meghna64.

@maskaravivek maskaravivek merged commit 3f490ff into commons-app:master Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text isn't formatted properly in Tutorial PageViews

3 participants