-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Translate #1285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate #1285
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1285 +/- ##
=========================================
- Coverage 3.81% 3.74% -0.08%
=========================================
Files 126 127 +1
Lines 5919 6032 +113
Branches 583 583
=========================================
Hits 226 226
- Misses 5678 5791 +113
Partials 15 15
Continue to review full report at Codecov.
|
|
As per #473 (comment), could you please get the user's Android language and use that language (for instance Japanese) to open the URL https://translatewiki.net/w/i.php?title=Special:Translate&language=ja&group=commons-android-strings&filter=%21translated&action=translate ? Thanks! |
|
I will change it accordingly , thanks :) |
|
@nicolas-raoul is there a list available for the values of language token that would into url for reference ? thanks |
|
@tanvidadu Great question, and actually a bit tricky! If you think it is too much work for now, you can also create an issue describing all that, and just leave the PR like it is now. Like you want! :-) |
|
Thanks :) @nicolas-raoul I will like to work on it. |
|
@nicolas-raoul I have the appropriate changes |
|
Thanks @tanvidadu it works as expected:) |
| <string name="about_rate_us"><u>Rate Us</u></string> | ||
| <string name="about_faq">Frequently Asked Questions</string> | ||
| <string name="welcome_skip_button">Skip Tutorial</string> | ||
| <string name="about_translate"><u>Translate</u></string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The things are not working in translatewiki.net at the moment unless escaped.
Description
Fixes #473
Added TextView in AboutActivity which links to https://translatewiki.net/w/i.php?title=Special:Translate&group=commons-android-strings&filter=!translated&action=translate
Screenshots showing what changed