Skip to content

Conversation

@tanvidadu
Copy link
Contributor

Description

Fixes #473

Added TextView in AboutActivity which links to https://translatewiki.net/w/i.php?title=Special:Translate&group=commons-android-strings&filter=!translated&action=translate

Screenshots showing what changed

translate

@codecov-io
Copy link

codecov-io commented Mar 11, 2018

Codecov Report

Merging #1285 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1285      +/-   ##
=========================================
- Coverage    3.81%   3.74%   -0.08%     
=========================================
  Files         126     127       +1     
  Lines        5919    6032     +113     
  Branches      583     583              
=========================================
  Hits          226     226              
- Misses       5678    5791     +113     
  Partials       15      15
Impacted Files Coverage Δ
...c/main/java/fr/free/nrw/commons/AboutActivity.java 0% <0%> (ø) ⬆️
...n/java/fr/free/nrw/commons/TokensTranslations.java 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80cc8b7...1b1568d. Read the comment docs.

@nicolas-raoul
Copy link
Member

As per #473 (comment), could you please get the user's Android language and use that language (for instance Japanese) to open the URL https://translatewiki.net/w/i.php?title=Special:Translate&language=ja&group=commons-android-strings&filter=%21translated&action=translate ?

Thanks!

@tanvidadu
Copy link
Contributor Author

I will change it accordingly , thanks :)

@tanvidadu
Copy link
Contributor Author

@nicolas-raoul is there a list available for the values of language token that would into url for reference ? thanks

@nicolas-raoul
Copy link
Member

@tanvidadu Great question, and actually a bit tricky!
The list of language codes can be deduced from the values* folder names here:
https://github.com/commons-app/apps-android-commons/tree/master/app/src/main/res
I suggest doing the matching and directing to English if no match is found.

If you think it is too much work for now, you can also create an issue describing all that, and just leave the PR like it is now. Like you want! :-)
Thanks!

@tanvidadu
Copy link
Contributor Author

Thanks :) @nicolas-raoul I will like to work on it.
I was thinking of implementing an spinner to get the required language and an hashmap to get the token for the selected language in the least possible time. But executing it might need some time as a lot of things need to be hardcoded.

@tanvidadu
Copy link
Contributor Author

@nicolas-raoul I have the appropriate changes

@neslihanturan
Copy link
Collaborator

Thanks @tanvidadu it works as expected:)

@neslihanturan neslihanturan merged commit 24641b5 into commons-app:master Mar 22, 2018
<string name="about_rate_us"><u>Rate Us</u></string>
<string name="about_faq">Frequently Asked Questions</string>
<string name="welcome_skip_button">Skip Tutorial</string>
<string name="about_translate"><u>Translate</u></string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The things are not working in translatewiki.net at the moment unless escaped.

@tanvidadu tanvidadu deleted the translate branch August 3, 2018 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants