Improve nominate for deletion feature

[diddypod]

Check status before nominating for deletion

Fixes #1335

• Checks for existence of Commons:Deletion_requests subpage and displays the deletion button accordingly.
• Reworked the button's appearance.
• Shows a TextView if the image has already been nominated.

Tests performed

Tested on Redmi 2, with betaDebug

Screenshots showing what changed

[codecov-io]

Codecov Report

Merging #1337 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1337      +/-   ##
=========================================
- Coverage    3.73%   3.72%   -0.02%     
=========================================
  Files         127     127              
  Lines        6054    6071      +17     
  Branches      588     590       +2     
=========================================
  Hits          226     226              
- Misses       5813    5830      +17     
  Partials       15      15

Impacted Files	Coverage Δ
...n/java/fr/free/nrw/commons/MediaDataExtractor.java	0% <0%> (ø)	⬆️
...fr/free/nrw/commons/media/MediaDetailFragment.java	0% <0%> (ø)	⬆️
...in/java/fr/free/nrw/commons/delete/DeleteTask.java	0% <0%> (ø)	⬆️
app/src/main/java/fr/free/nrw/commons/Media.java	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe1f0b5...a449870. Read the comment docs.

[neslihanturan]

Do you think this is done @diddypod ? I have tested it but previous version looked better to me since this one is not informative.

Currently, if user nominates an image for deletion, media view button becomes disabled with same UI, but it is frustrating when you click to a button and nothing happens (no message, no change in buttons UI etc.).

To see this image is already nominated message, user have to go back and come back to media details activity. Which is not user frinedly:/

[diddypod]

Thanks for the feedback, @neslihanturan. I'll change that behaviour. Appearance wise, is everything okay?

[neslihanturan]

I liked the appearance @diddypod , if you can manage to change buttons visibility without needing re-starting the activity, this feature will be greatly done:)

Besides, what is your opinion to displaying "nomination process" to the user in some way? Since I know it takes some time, I am waiting to see success message. However, users don't know it. They may feel like clicked and nothing happened for 5 seconds.

I suggest to discuss this UI under the discussion, before the implementation. This PR can wait the result of the discussion

[diddypod]

I think some ways to display the ongoing deletion process would be

• an indefinite progress bar
• an alert with a progress bar and the exact status of the deletion process
• a series of Toasts, as each part of the tasks is completed
• an notification with a progress bar and status of the deletion of the process

I prefer the second one. @neslihanturan , what do you say?

[neslihanturan]

@diddypod can you move your last comment under discussion please? Only code related discusions are preferable here. We need to get opinions from whole team to answer this questions:)

[diddypod]

Travis CI build keeps failing and I don't understand why. Could you please help @neslihanturan @nicolas-raoul?

[neslihanturan]

It will keep fail @diddypod dont worry about it for a week. Then the peoblem will be solved.

[misaochan]

Shall we merge this, if everything works aside from the failing tests?

[neslihanturan]

I didn't test it after last commits @misaochan will be able to do on monday

[neslihanturan]

Thanks @diddypod , this was a really needed feature

[misaochan]

Agreed, thanks @diddypod ! 👍