Fix issue #1332 : Contribution Image auto/manual refresh if fetching fails

[devaar100]

Description

Fixes #1332
Addition of a swipe refresh layout to enable manual refresh

Tests performed

Tested on Android version 6.0.1

[neslihanturan]

As we talked on issue, we prefer auto refresh, not manual swipe refresh. Let ask @misaochan if this is suitable?

[misaochan]

I think adding swipe refresh as a backup could be a good idea, especially if people don't want to wait for an auto-refresh. When I tested real-time movement recently in a car, I could move out of the range of the Nearby pins without an auto-refresh happening.

[misaochan]

Oh wait, sorry, this is for contributions? Swipe refresh should be OK for that too. I would be against adding a refresh button though.

[neslihanturan]

I still don't understand why we would need a swipe refresh while we have already auto refresh. Besides, this breaks tests :(

But if everyone agrees, then we should add it to our codebase. @devaar100 would you like to investigate why tests fails?

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (2.7.x-release@1bede8f). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff               @@
##             2.7.x-release   #1375   +/-   ##
===============================================
  Coverage                 ?   3.28%           
===============================================
  Files                    ?     128           
  Lines                    ?    6877           
  Branches                 ?     674           
===============================================
  Hits                     ?     226           
  Misses                   ?    6636           
  Partials                 ?      15

Impacted Files	Coverage Δ
...w/commons/contributions/ContributionsActivity.java	0% <ø> (ø)
...mmons/contributions/ContributionsListFragment.java	0% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bede8f...27a8ce9. Read the comment docs.

[neslihanturan]

Thanks @devaar100 it worked for me

[misaochan]

It seems that this has been merged into the wrong branch - it should have gone to master instead of 2.7.x-release. I apologize but I will have to revert this, as we need to do an urgent hotfix to production for #1599 that will bypass beta testing, and this PR cannot be included in it.

I will revert this from the 2.7.x-release branch, but it should still exist in master because I have updated master with that branch. Please let me know if there are issues with it.