Change email address for logs to private mailing list #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.7.x-release #1404 +/- ##
=============================================
Coverage 3.31% 3.31%
=============================================
Files 128 128
Lines 6809 6809
Branches 669 669
=============================================
Hits 226 226
Misses 6568 6568
Partials 15 15
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned at #891 , WMF has pretty strict rules about how we maintain user privacy if we are to remain on their Play Store account. When the user taps "send log file" in Settings, they should be sending the file to the private forum (only accessed by devs who have signed the NDA), not the public one.
This is the 3rd time I have needed to make this change, as it keeps being overridden :( (see #974 and #1000). I have modified the variable names and removed header sharing with the feedback option to be even more explicit. Please please be aware of this.