Help button

[97balakrishnan]

Description

Fixes #1397

Added a button to open the wikimedia commons help page at the end of the tutorial

Tests performed

Tested on Android 6.0.1 Moto G3

Screenshots showing what changed

[codecov-io]

Codecov Report

Merging #1415 into master will decrease coverage by 0.11%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1415      +/-   ##
=========================================
- Coverage     3.3%   3.18%   -0.12%     
=========================================
  Files         128     132       +4     
  Lines        6839    7092     +253     
  Branches      669     682      +13     
=========================================
  Hits          226     226              
- Misses       6598    6851     +253     
  Partials       15      15

Impacted Files	Coverage Δ
.../java/fr/free/nrw/commons/WelcomePagerAdapter.java	0% <0%> (ø)	⬆️
...free/nrw/commons/theme/NavigationBaseActivity.java	22.82% <0%> (-0.77%)	⬇️
.../java/fr/free/nrw/commons/auth/SessionManager.java	16.66% <0%> (-0.48%)	⬇️
...n/java/fr/free/nrw/commons/auth/LoginActivity.java	0% <0%> (ø)	⬆️
.../fr/free/nrw/commons/di/ActivityBuilderModule.java	0% <0%> (ø)	⬆️
.../fr/free/nrw/commons/nearby/NearbyMapFragment.java	0% <0%> (ø)	⬆️
...ee/nrw/commons/media/MediaDetailPagerFragment.java	0% <0%> (ø)	⬆️
.../fr/free/nrw/commons/di/FragmentBuilderModule.java	0% <0%> (ø)	⬆️
...nrw/commons/upload/MultipleUploadListFragment.java	0% <0%> (ø)	⬆️
...ava/fr/free/nrw/commons/nearby/NearbyActivity.java	0% <0%> (ø)	⬆️
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22772c8...b5289b0. Read the comment docs.

[maskaravivek]

IMO, we should keep Yes as the primary action and More Help as the secondary one. So, More Help can be just a link instead of a button.

@neslihanturan @misaochan your thoughts?

[misaochan]

Sorry, just managed to look at this. I definitely agree that the "more help" action should be the secondary one. I would recommend a link in the bottom right corner instead.

Additionally, perhaps "more information" might be better than "more help"?

What do you think @neslihanturan ?

[97balakrishnan]

Ok I'll make the changes

[97balakrishnan]

Is top right better ? @misaochan

[misaochan]

I'd personally go with bottom right, but we can wait for Neslihan to weigh in. :)

[97balakrishnan]

Ok :)

[97balakrishnan]

I've initially pushed the top right version, will modify after further discussions :)

[neslihanturan]

Bottom right is better for me too @misaochan

[97balakrishnan]

Okk I'll change that @neslihanturan

[maskaravivek]

@97balakrishnan were you able to make this change. We can go ahead and merge it once the UI is fixed. :)

[97balakrishnan]

Sorry for the long delay

[97balakrishnan]

[neslihanturan]

Works as intended @97balakrishnan , thanks!