Skip to content

Conversation

@psh
Copy link
Collaborator

@psh psh commented Apr 7, 2018

Description

Related to the discussion on issue #1389, this PR moves the Java unit test suite over to Kotlin.

Changes of note:

  • Updated the version of Kotlin to match the latest release (note: Kotlin is still only a test dependency, so not enabled for use in the production codebase)
  • Slight change of order in the build.gradle dependencies to tidy things up.
  • Utilized the more idiomatic Mockito-Kotlin (MIT licensed) in tests.

Tests performed

All unit tests, across all build variants, run cleanly.

@codecov-io
Copy link

Codecov Report

Merging #1428 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1428   +/-   ##
======================================
  Coverage     3.3%    3.3%           
======================================
  Files         128     128           
  Lines        6839    6839           
  Branches      669     669           
======================================
  Hits          226     226           
  Misses       6598    6598           
  Partials       15      15
Impacted Files Coverage Δ
...java/fr/free/nrw/commons/category/CategoryDao.java 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b2dd8c...ac0c477. Read the comment docs.

@misaochan
Copy link
Member

@psh Wonderful, thank you! :) Looks good to me in general, but it would be good if someone familiar with Kotlin (@maskaravivek ?) could review this before we merge.

@maskaravivek
Copy link
Contributor

Looks good to me as well. The PR simply converts Java code to Kotlin. As long as the checks are passing, it should be okay. :)

@misaochan
Copy link
Member

Thanks all! Would be great if we could get a section in the wiki about this, also. :)

@misaochan misaochan merged commit 22772c8 into commons-app:master Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants