Skip to content

Conversation

@maskaravivek
Copy link
Contributor

Description

Fixes #1393

After the changes in how the authCookie is stored and used after the 2FA changes, we are forced to log out the user if he is coming from an older version. This PR checks for the cached values and if those values are not present, the user is asked to login again.

@maskaravivek maskaravivek changed the base branch from master to 2.7.x-release April 19, 2018 05:34
@codecov-io
Copy link

Codecov Report

Merging #1454 into 2.7.x-release will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff                @@
##           2.7.x-release   #1454      +/-   ##
================================================
+ Coverage           3.28%    3.3%   +0.01%     
================================================
  Files                128     128              
  Lines               6870    6848      -22     
  Branches             673     671       -2     
================================================
  Hits                 226     226              
+ Misses              6629    6607      -22     
  Partials              15      15
Impacted Files Coverage Δ
.../java/fr/free/nrw/commons/auth/SessionManager.java 16.66% <0%> (-0.48%) ⬇️
...n/java/fr/free/nrw/commons/auth/LoginActivity.java 0% <0%> (ø) ⬆️
.../fr/free/nrw/commons/nearby/NearbyMapFragment.java 0% <0%> (ø) ⬆️
.../free/nrw/commons/upload/SingleUploadFragment.java 0% <0%> (ø) ⬆️
...ava/fr/free/nrw/commons/nearby/NearbyActivity.java 0% <0%> (ø) ⬆️
...java/fr/free/nrw/commons/category/CategoryDao.java 0% <0%> (ø) ⬆️
...e/nrw/commons/location/LocationServiceManager.java 0% <0%> (ø) ⬆️
...fr/free/nrw/commons/nearby/NearbyListFragment.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b129a6...9b2dabd. Read the comment docs.

@neslihanturan
Copy link
Collaborator

Works like a charm @maskaravivek !

@neslihanturan neslihanturan merged commit 8b118b3 into commons-app:2.7.x-release Apr 19, 2018
@maskaravivek maskaravivek deleted the contributionFix branch September 12, 2018 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants