Skip to content

Fix conflicts at #1352 fix memory leaks and lint warnings (they happened due to hiding keyboard) #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2018

Conversation

neslihanturan
Copy link
Collaborator

Description

Fixes conflicts at #1352 , so that I can merge.

Tests performed

Tested on API 25, betaDebug

@codecov-io
Copy link

codecov-io commented Apr 30, 2018

Codecov Report

Merging #1471 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1471      +/-   ##
=========================================
+ Coverage    3.21%   3.25%   +0.03%     
=========================================
  Files         132     132              
  Lines        7088    7196     +108     
  Branches      680     707      +27     
=========================================
+ Hits          228     234       +6     
- Misses       6845    6947     +102     
  Partials       15      15
Impacted Files Coverage Δ
...n/java/fr/free/nrw/commons/auth/LoginActivity.java 0% <0%> (ø) ⬆️
...e/nrw/commons/category/CategorizationFragment.java 0% <0%> (ø) ⬆️
...free/nrw/commons/upload/MultipleShareActivity.java 0% <0%> (ø) ⬆️
...nrw/commons/upload/MultipleUploadListFragment.java 0% <0%> (ø) ⬆️
.../free/nrw/commons/upload/SingleUploadFragment.java 0% <0%> (ø) ⬆️
...fr/free/nrw/commons/settings/SettingsFragment.java 25.51% <0%> (-4.49%) ⬇️
.../fr/free/nrw/commons/utils/StringSortingUtils.java 73.91% <0%> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c2cc26...d1fa26f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants