Skip to content

Conversation

@ujjwalagrawal17
Copy link
Contributor

Description

Fixes #1487

Deleted hidekeyboard method from various fragments and add a static method in ViewUtil.java for reusing the code. used staic method in various fragments, activities.

Tests performed

Manually Tested on API 25(Moto G5S+)with {debug variant}

@codecov-io
Copy link

Codecov Report

Merging #1488 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1488      +/-   ##
=========================================
+ Coverage     3.2%   3.21%   +<.01%     
=========================================
  Files         132     132              
  Lines        7109    7090      -19     
  Branches      686     682       -4     
=========================================
  Hits          228     228              
+ Misses       6866    6847      -19     
  Partials       15      15
Impacted Files Coverage Δ
...nrw/commons/upload/MultipleUploadListFragment.java 0% <0%> (ø) ⬆️
.../free/nrw/commons/upload/SingleUploadFragment.java 0% <0%> (ø) ⬆️
...java/fr/free/nrw/commons/upload/ShareActivity.java 0% <0%> (ø) ⬆️
.../main/java/fr/free/nrw/commons/utils/ViewUtil.java 0% <0%> (ø) ⬆️
...n/java/fr/free/nrw/commons/auth/LoginActivity.java 0% <0%> (ø) ⬆️
...e/nrw/commons/category/CategorizationFragment.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35f05be...924d749. Read the comment docs.

@maskaravivek maskaravivek merged commit d3597b8 into commons-app:master May 2, 2018
@ujjwalagrawal17 ujjwalagrawal17 deleted the update_viewutils branch May 2, 2018 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants