Skip to content

back button functionality #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2018
Merged

back button functionality #1517

merged 1 commit into from
Jun 19, 2018

Conversation

tanvidadu
Copy link
Contributor

Description (required)

Fixes #1510

Pressing "Back" in zoom goes back to ShareActivity.

Tests performed (required)

Tested on betaDebug.

@codecov-io
Copy link

codecov-io commented May 15, 2018

Codecov Report

Merging #1517 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1517      +/-   ##
=========================================
- Coverage    3.86%   3.85%   -0.01%     
=========================================
  Files         151     151              
  Lines        7587    7595       +8     
  Branches      710     711       +1     
=========================================
  Hits          293     293              
- Misses       7277    7285       +8     
  Partials       17      17
Impacted Files Coverage Δ
...java/fr/free/nrw/commons/upload/ShareActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6c18c6...26c9aca. Read the comment docs.

@misaochan
Copy link
Member

Oops, I'm currently halfway through #1091 , which includes tidying up the zoom code. Would it be okay to hold off on merging this until that has been merged? I think it would be better to add this to a tidier ShareActivity, rather than the other way around. :)

@tanvidadu
Copy link
Contributor Author

No problem ! :)

@maskaravivek
Copy link
Member

@tanvidadu Can you resolve the merge conflicts for this PR. This can be tested and merge after that.

@tanvidadu
Copy link
Contributor Author

@maskaravivek I have resolved the merge conflicts !

@misaochan misaochan merged commit ac2de1a into commons-app:master Jun 19, 2018
@misaochan
Copy link
Member

Thanks for your patience with the refactor, @tanvidadu . :)

neslihanturan pushed a commit to neslihanturan/apps-android-commons that referenced this pull request Jul 16, 2018
@tanvidadu tanvidadu deleted the back branch August 3, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants