Skip to content

Conversation

@whym
Copy link
Collaborator

@whym whym commented Jun 5, 2018

Title

Fixes #465 (Disabling LineLength Codacy check?)

Description

Changes the max line length defined in the Checkstyle rules to 140 characters. This value is used in our continuous integration. Per discussion in #465, it seems sensible to a higher max line length.

Tests performed

I checked with Travis CI and gradle checkstyle.

@codecov-io
Copy link

codecov-io commented Jun 5, 2018

Codecov Report

Merging #1590 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1590   +/-   ##
======================================
  Coverage    3.86%   3.86%           
======================================
  Files         149     149           
  Lines        7576    7576           
  Branches      721     721           
======================================
  Hits          293     293           
  Misses       7266    7266           
  Partials       17      17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d45b2...6cc23ab. Read the comment docs.

@misaochan misaochan merged commit 862318c into commons-app:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants