-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Introducing a brief exp of Image License #1596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The PR is ready for riview @misaochan @maskaravivek ! I am facing this error in Travis :
|
@tanvidadu I have restarted the build. Let's hope that it doesn't get stalled this time. |
Codecov Report
@@ Coverage Diff @@
## master #1596 +/- ##
=========================================
- Coverage 3.87% 3.84% -0.04%
=========================================
Files 150 151 +1
Lines 7560 7623 +63
Branches 708 708
=========================================
Hits 293 293
- Misses 7250 7313 +63
Partials 17 17
Continue to review full report at Codecov.
|
The screenshot looks good to me. :) Should we make a new branch for the tutorial task, though, instead of merging to master? Admittedly this PR could be standalone, but if we merge to master we will need to test it first. |
I submitted this pr as a standalone as it is not directly related to quiz and tutorial, But we can surely direct it to new branch :) |
Great job @tanvidadu , works for me. Sorry for long review time, we were busy with IEG tasks. Thanks for your contribution and patience:) |
This is a nice little feature addition. :) |
Introducing a brief explanation of Image License
Fixes #1316
Description (required)
Added a (?) link at the right of spinner, that opens https://commons.wikimedia.org/wiki/Commons:First_steps/License_selection in the user's language
Tests performed (required)
Tested on ProdDebug with languages English and Hindi.
Screenshots showing what changed (optional)
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.