Skip to content

Introducing a brief exp of Image License #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2018

Conversation

tanvidadu
Copy link
Contributor

Introducing a brief explanation of Image License

Fixes #1316

Description (required)

Added a (?) link at the right of spinner, that opens https://commons.wikimedia.org/wiki/Commons:First_steps/License_selection in the user's language

Tests performed (required)

Tested on ProdDebug with languages English and Hindi.

Screenshots showing what changed (optional)

Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

@tanvidadu
Copy link
Contributor Author

The PR is ready for riview @misaochan @maskaravivek !

I am facing this error in Travis :

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

@maskaravivek
Copy link
Member

@tanvidadu I have restarted the build. Let's hope that it doesn't get stalled this time.

@codecov-io
Copy link

Codecov Report

Merging #1596 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1596      +/-   ##
=========================================
- Coverage    3.87%   3.84%   -0.04%     
=========================================
  Files         150     151       +1     
  Lines        7560    7623      +63     
  Branches      708     708              
=========================================
  Hits          293     293              
- Misses       7250    7313      +63     
  Partials       17      17
Impacted Files Coverage Δ
.../free/nrw/commons/upload/SingleUploadFragment.java 0% <0%> (ø) ⬆️
...in/java/fr/free/nrw/commons/upload/UrlLicense.java 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f47d39...a934d24. Read the comment docs.

@misaochan
Copy link
Member

misaochan commented Jun 8, 2018

The screenshot looks good to me. :) Should we make a new branch for the tutorial task, though, instead of merging to master? Admittedly this PR could be standalone, but if we merge to master we will need to test it first.

@tanvidadu
Copy link
Contributor Author

I submitted this pr as a standalone as it is not directly related to quiz and tutorial, But we can surely direct it to new branch :)

@neslihanturan
Copy link
Collaborator

Great job @tanvidadu , works for me. Sorry for long review time, we were busy with IEG tasks. Thanks for your contribution and patience:)

@neslihanturan neslihanturan merged commit faee423 into commons-app:master Jul 22, 2018
@maskaravivek
Copy link
Member

This is a nice little feature addition. :)

@tanvidadu tanvidadu deleted the imageLicense branch August 3, 2018 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants