Skip to content

Delete unused imports #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Delete unused imports #1606

merged 1 commit into from
Jun 20, 2018

Conversation

dlsrks1021
Copy link
Contributor

Title (required)

Delete unused imports

Description (required)

Delete unnecessary imports for optimizing.

Tests performed (required)

@codecov-io
Copy link

codecov-io commented Jun 9, 2018

Codecov Report

Merging #1606 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1606      +/-   ##
=========================================
+ Coverage    3.85%   3.87%   +0.01%     
=========================================
  Files         151     150       -1     
  Lines        7595    7560      -35     
  Branches      711     708       -3     
=========================================
  Hits          293     293              
+ Misses       7285    7250      -35     
  Partials       17      17
Impacted Files Coverage Δ
...ain/java/fr/free/nrw/commons/utils/ImageUtils.java 0% <ø> (ø) ⬆️
.../java/fr/free/nrw/commons/nearby/DirectUpload.java 0% <ø> (ø) ⬆️
...java/fr/free/nrw/commons/upload/UploadService.java 0% <ø> (ø) ⬆️
...ee/nrw/commons/media/MediaDetailPagerFragment.java 0% <ø> (ø) ⬆️
.../free/nrw/commons/di/CommonsApplicationModule.java 50% <ø> (ø) ⬆️
...java/fr/free/nrw/commons/upload/ShareActivity.java 0% <ø> (ø) ⬆️
...fr/free/nrw/commons/media/MediaDetailFragment.java 0% <ø> (ø) ⬆️
...c/main/java/fr/free/nrw/commons/AboutActivity.java 0% <ø> (ø) ⬆️
...ree/nrw/commons/contributions/ContributionDao.java 0% <ø> (ø) ⬆️
...n/java/fr/free/nrw/commons/CommonsApplication.java 30.61% <ø> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2de1a...42e5b5f. Read the comment docs.

build.gradle Outdated
@@ -16,9 +16,9 @@ buildscript {

allprojects {
repositories {
jcenter()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on cleanup. Removing unused imports makes sense but does this change in build.gradle make any difference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of issue #1607 , I had to change build.gradle. However, I don't want to change build.gradle in this PR and I reset the gradle in commit 'Update build.gradle'. So, this PR don't have any change about gradle.
Thank you for replying!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean you removed the 'Update build.gradle' commit already locally? If so, please amend and update your public branch.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dlsrks1021 any update?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed 'Update build.gradle' commit and modify 'remove unused imports' commit to do not change build.gradle.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@whym whym merged commit e8b2dd7 into commons-app:master Jun 20, 2018
neslihanturan pushed a commit to neslihanturan/apps-android-commons that referenced this pull request Jul 16, 2018
neslihanturan added a commit to neslihanturan/apps-android-commons that referenced this pull request Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants