-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Delete unused imports #1606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete unused imports #1606
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1606 +/- ##
=========================================
+ Coverage 3.85% 3.87% +0.01%
=========================================
Files 151 150 -1
Lines 7595 7560 -35
Branches 711 708 -3
=========================================
Hits 293 293
+ Misses 7285 7250 -35
Partials 17 17
Continue to review full report at Codecov.
|
build.gradle
Outdated
@@ -16,9 +16,9 @@ buildscript { | |||
|
|||
allprojects { | |||
repositories { | |||
jcenter() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on cleanup. Removing unused imports makes sense but does this change in build.gradle make any difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of issue #1607 , I had to change build.gradle. However, I don't want to change build.gradle in this PR and I reset the gradle in commit 'Update build.gradle'. So, this PR don't have any change about gradle.
Thank you for replying!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean you removed the 'Update build.gradle' commit already locally? If so, please amend and update your public branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dlsrks1021 any update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed 'Update build.gradle' commit and modify 'remove unused imports' commit to do not change build.gradle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
This reverts commit cc74b98.
Title (required)
Delete unused imports
Description (required)
Delete unnecessary imports for optimizing.
Tests performed (required)