Skip to content

Conversation

@maskaravivek
Copy link
Contributor

Title (required)

Fixes B part of #1545.

Description (required)

Fixes part of #1545

Fix resource not found exception with null checks

Tests performed (required)

Wasn't able to reproduce the bug but null checks should prevent the crashes.

@codecov-io
Copy link

Codecov Report

Merging #1628 into 2.8-release will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##           2.8-release   #1628      +/-   ##
==============================================
- Coverage         3.87%   3.87%   -0.01%     
==============================================
  Files              150     150              
  Lines             7567    7571       +4     
  Branches           708     710       +2     
==============================================
  Hits               293     293              
- Misses            7257    7261       +4     
  Partials            17      17
Impacted Files Coverage Δ
...w/commons/contributions/ContributionsActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e9af3c...bf20489. Read the comment docs.

@misaochan
Copy link
Member

Thanks @maskaravivek !

@misaochan misaochan merged commit 1dc0a7c into commons-app:2.8-release Jun 14, 2018
@maskaravivek maskaravivek deleted the resourceCrashFix branch September 12, 2018 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants