Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
c959321
Update issue_template.md
misaochan May 2, 2018
3f47d39
Localisation updates from https://translatewiki.net.
translatewiki Jun 7, 2018
3b6c94c
Modify allow_gps_summary string (#1608)
misaochan Jun 11, 2018
a772b97
Merge remote-tracking branch 'refs/remotes/origin/2.7.x-release'
misaochan Jun 11, 2018
1adb052
Revert "Fix issue #1332 : Contribution Image auto/manual refresh if f…
misaochan Jun 11, 2018
89defc5
Versioning and changelog for v2.7.2 (#1610)
misaochan Jun 11, 2018
8d62103
add parameters to sort featured images by order of recency
neoliteconsultant Jun 5, 2018
7f02524
Add comments to parameters for sorting featured images
neoliteconsultant Jun 6, 2018
699d150
Merge remote-tracking branch 'refs/remotes/origin/2.7.x-release'
misaochan Jun 12, 2018
887f152
Merge remote-tracking branch 'refs/remotes/origin/2.8-release'
misaochan Jun 12, 2018
135d885
Correct name is "Wikidata", not "wiki data"
nemobis Jun 12, 2018
a0fe8b0
Fix#1479 (#1547)
Jun 14, 2018
2cfbb67
Added Basic Pic Of the Day App Widget (#1523)
madhurgupta10 Jun 14, 2018
b76746c
Localisation updates from https://translatewiki.net.
translatewiki Jun 14, 2018
c6ba0f1
Create utility class for contribution process
neslihanturan Jun 16, 2018
8ee81fa
implement method to save five from given URİ
neslihanturan Jun 16, 2018
a327ee2
Add file utilities for directory checks
neslihanturan Jun 16, 2018
e77b83a
Add ContributionUtils for saving file during upload
neslihanturan Jun 16, 2018
f6c18c6
Localisation updates from https://translatewiki.net.
translatewiki Jun 18, 2018
ac2de1a
back button functionality (#1517)
tanvidadu Jun 19, 2018
e8b2dd7
remove unused imports (#1606)
dlsrks1021 Jun 20, 2018
7d393dd
Localisation updates from https://translatewiki.net.
translatewiki Jun 21, 2018
54246fd
Merge remote-tracking branch 'refs/remotes/origin/2.8-release'
misaochan Jun 23, 2018
43d9f0d
Merge branch 'master' of https://github.com/commons-app/apps-android-…
misaochan Jun 23, 2018
5dab7e3
Change method call acordingly with handleImagePicked() method
neslihanturan Jun 23, 2018
6f4e677
Call method to save file temproarily when a photo to upload is chosen…
neslihanturan Jun 23, 2018
198ffe9
Call method to save file temproarily when a photo to upload is chosen…
neslihanturan Jun 23, 2018
733a48b
Arrange method call
neslihanturan Jun 23, 2018
e296d03
Write a method to save file temporarily during upload process. It wil…
neslihanturan Jun 23, 2018
3e5b87a
Add a method to save a file to a given path from a content provider Uri
neslihanturan Jun 23, 2018
b077496
On openAssetFileDescriptor method, use URi from temporarily saved fil…
neslihanturan Jun 23, 2018
6330ff4
Edit uploadContribution method so that it will use FileInputStream fr…
neslihanturan Jun 23, 2018
2616a51
Make it work
neslihanturan Jun 23, 2018
d8301b0
Code cleanup
neslihanturan Jun 23, 2018
185a7fd
Merge master into branch
neslihanturan Jun 23, 2018
52fe572
Add directory cleaner method
neslihanturan Jun 23, 2018
fa09813
Call temp directory cleaner method at the end of uplpoad process
neslihanturan Jun 23, 2018
1e6c48b
Use FileInputStream insted
neslihanturan Jun 23, 2018
bd3ada1
Add directory cleaner method
neslihanturan Jun 23, 2018
e05993f
Localisation updates from https://translatewiki.net.
translatewiki Jun 25, 2018
730c34b
Merge master into branch
neslihanturan Jun 26, 2018
262b523
Add file removal method
neslihanturan Jun 26, 2018
8513bc7
Use external directory instead
neslihanturan Jun 27, 2018
ef5f3c4
Make destination file name flexible
neslihanturan Jun 27, 2018
c1c178c
Fix nearby crash by updating to Mapbox version that includes telem 2.…
nicolas-raoul Jun 27, 2018
4dc80d3
Make it work with share action coming from another activity
neslihanturan Jun 27, 2018
5e63437
Make it work for Multiple hare Activity
neslihanturan Jun 27, 2018
c3fecdd
Code cleanup
neslihanturan Jun 27, 2018
044cbc3
Fix conflicts
neslihanturan Jun 27, 2018
0092451
Localisation updates from https://translatewiki.net.
translatewiki Jun 28, 2018
7797048
Add description to "steps to reproduce"
misaochan Jun 28, 2018
88d2038
Fix tamil translation of app name (#1679)
sivaraam Jun 30, 2018
6fba2eb
Merge pull request #1484 from commons-app/issue-template-change
neslihanturan Jul 1, 2018
0ebb84c
Merge remote-tracking branch 'upstream/master' into fixUrgentCrashesA…
neslihanturan Jul 1, 2018
e1d0852
Solve camera issue
neslihanturan Jul 1, 2018
d3f8ffa
Localisation updates from https://translatewiki.net.
translatewiki Jul 2, 2018
107729c
Merge remote-tracking branch 'refs/remotes/origin/2.8-release'
misaochan Jul 4, 2018
1e49438
Merge branch 'master' of https://github.com/commons-app/apps-android-…
misaochan Jul 4, 2018
fa6353b
Localisation updates from https://translatewiki.net.
translatewiki Jul 5, 2018
9456732
Fix camera crash
neslihanturan Jul 7, 2018
d7b956e
dependency-injection.md: fix some typos (#1681)
san1j Jul 7, 2018
b6d076e
Cleanup
neslihanturan Jul 7, 2018
2332904
Fix conflicts
neslihanturan Jul 7, 2018
6580b46
Revert change of commenting out posibly useles code, because I am not…
neslihanturan Jul 12, 2018
1b6bfd1
Use timestamp in temoorary file names, so that we wont never create s…
neslihanturan Jul 12, 2018
a7a8061
Code cleanup
neslihanturan Jul 12, 2018
544c0f5
Add nullable annotation to handleImagePicked method uri parameter
neslihanturan Jul 12, 2018
b275126
Add Nullable anotation to method
neslihanturan Jul 12, 2018
b531e92
Code cleanup
neslihanturan Jul 12, 2018
3d8d191
Fix conflicts
neslihanturan Jul 12, 2018
a31e4cc
Bugfix: use uri.getPath() instead uri.toString
neslihanturan Jul 12, 2018
a47fe4b
Remove unecesarry file saving operation, which was added accidentally
neslihanturan Jul 12, 2018
8ac9205
Fix travis fail
neslihanturan Jul 12, 2018
a280c0c
Remove temp file if upload gets failed and file is still there
neslihanturan Jul 13, 2018
03b0ef5
Code cleanup:Remove unused parameters from removeTempFile method
neslihanturan Jul 13, 2018
bbb9a87
Empty temp directory on app create, in case some of files are still t…
neslihanturan Jul 13, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add nullable annotation to handleImagePicked method uri parameter
  • Loading branch information
neslihanturan committed Jul 12, 2018
commit 544c0f50f3056dbb951526fe2bb993fe5a83197b
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import android.net.Uri;
import android.os.Bundle;
import android.provider.MediaStore;
import android.support.annotation.Nullable;
import android.support.v4.app.Fragment;
import android.support.v4.app.FragmentActivity;
import android.support.v4.content.FileProvider;
Expand Down Expand Up @@ -91,7 +92,7 @@ public void startGalleryPick() {
fragment.startActivityForResult(pickImageIntent, SELECT_FROM_GALLERY);
}

public void handleImagePicked(int requestCode, Uri uri, boolean isDirectUpload, String wikiDataEntityId) {
public void handleImagePicked(int requestCode, @Nullable Uri uri, boolean isDirectUpload, String wikiDataEntityId) {
FragmentActivity activity = fragment.getActivity();
Timber.d("handleImagePicked() called with onActivityResult()");
Intent shareIntent = new Intent(activity, ShareActivity.class);
Expand Down