Fix issue where Wikidata edits were not happening #1682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@nicolas-raoul @VojtechDostal Wikidata edits should hopefully work on this branch. :) Let me know if you guys need an APK for testing on this build. |
Codecov Report
@@ Coverage Diff @@
## 2.8-release #1682 +/- ##
==============================================
- Coverage 3.86% 3.85% -0.01%
==============================================
Files 150 151 +1
Lines 7576 7591 +15
Branches 711 712 +1
==============================================
Hits 293 293
- Misses 7266 7281 +15
Partials 17 17
Continue to review full report at Codecov.
|
Member
|
Just tested this on prodDebug, Android 8.0, Misaochan2 account, Samsung Galaxy S7 device. The Wikidata edit for https://www.wikidata.org/wiki/Q21904082 failed with the toast "Failed to update corresponding Wikidata entity", but the upload succeeded. Logs, taken from debug level, filtered for 'fr.free' (I started from a couple minutes before the failure toast, since I don't know how far back you need them). Sorry for the verbosity, I don't really know how else to filter more specifically with a real device. If it's too difficult to process the logs, I can re-test with an emulator which will have simpler logs: |
Contributor
Author
|
@misaochan Can you retry with a fresh installation. I got the same error when I installed prodDebug over betaDebug(without uninstalling betaDebug). On uninstalling and reinstalling the app, the edit was successful for me. I suspect the account info is not cleared properly on logout/upgrade. |
Member
|
@maskaravivek It does work with a fresh install. :) Should we catch that exception and prompt user to re-login though? I mean, users won't be using beta of course, but the same issue can happen when their app updates to a new version. |
Contributor
Author
|
@misaochan I don't think it will happen while updating the app (I will validate this once). The problem is when the user switches from Moreover, currently as we have different package names for beta(fr.free.nrw.commons.debug) and prod(fr.free.nrw.commons) both apps should coexist. Right now if you install the In nutshell, the issue is in how the accounts and app variants are being handled. I would like to fix this is a separate PR. :) |
Member
|
@maskaravivek Thanks for the clarification! I agree, best to fix that in a separate PR. :) |
Member
|
Can this branch be deleted now? |
Member
|
I think so. Please confirm @maskaravivek |
Contributor
Author
|
Yes it can be deleted. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title (required)
Fixes #1637
Description (required)
Fixes #1637
I was unable to make Wikidata edits both from
masterand2.8-releasebranch. This PR adds a lot of logs so that debugging in future is easier and it also fixes the issue.Now, Wikidata edits are happening properly.
Tests performed (required)
Tested on ProdDebug