Force login when no active session is found while uploading an image #1684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.8-release #1684 +/- ##
==============================================
- Coverage 3.87% 3.86% -0.01%
==============================================
Files 150 150
Lines 7571 7576 +5
Branches 710 711 +1
==============================================
Hits 293 293
- Misses 7261 7266 +5
Partials 17 17
Continue to review full report at Codecov.
|
misaochan
requested changes
Jul 2, 2018
There was a problem hiding this comment.
Thanks for submitting this @maskaravivek . Looks good to me, submitted a suggestion for a string change.
app/src/main/res/values/strings.xml
Outdated
| @@ -287,4 +287,6 @@ | |||
| <string name="wikidata_edit_failure">Failed to update corresponding Wikidata entity!</string> | |||
| <string name="menu_set_wallpaper">Set wallpaper</string> | |||
| <string name="wallpaper_set_successfully">Wallpaper set successfully!</string> | |||
|
|
|||
| <string name="user_not_logged_in">No active session found for this user.</string> | |||
There was a problem hiding this comment.
Probably more user-friendly to say something like: "Login session expired, please log in again" ?
misaochan
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title (required)
Fixes part of #1545.
Description (required)
The only could that could be null in the
startUploadmethod ofUploadControllerisnamefield ofCurrentAccount. Have added a null check for the same and will be redirecting the user to login if the session is null.Tests performed (required)
Unable to reproduce the issue but this check should ideally prevent the crash and redirect the user to login.