-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix preview crash on local files during upload #1696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix preview crash on local files during upload #1696
Conversation
…ulting to the English version. Tested with Spanish on physical Android device. Other notes: Difficulties building with gradle due to dexcount plugin: KeepSafe/dexcount-gradle-plugin#234. In testing, disabled the plugin.
Codecov Report
@@ Coverage Diff @@
## master #1696 +/- ##
=========================================
+ Coverage 3.85% 3.87% +0.02%
=========================================
Files 151 151
Lines 7604 7612 +8
Branches 714 716 +2
=========================================
+ Hits 293 295 +2
- Misses 7294 7300 +6
Partials 17 17
Continue to review full report at Codecov.
|
And, I didn't experienced the difficulty about " building with gradle due to dexcount plugin: KeepSafe/dexcount-gradle-plugin#234. In testing, disabled the plugin." you mentioned. Did you solve that problem? |
I can take a look at #1734 |
Title (required)
Fixes App crashes when tapping on an image during multiple share #1653
Description (required)
Fixes App crashes when tapping on an image during multiple share #1653
Tests performed (required)
Tested on Samsung Galaxy S6 Android 7.0 API 24, with Debug
Gradle build via AndroidStudio
Request from reviewer: Which build tasks do I run to do verification or is the default build from Android Studio sufficient?