Skip to content

Conversation

@maskaravivek
Copy link
Contributor

Fix conflict between different product flavors so that beta and prod apps could coexist

Title (required)

Fixes #1725

Tests performed (required)

Able to install and log in to both beta and prod flavors of the app simultaneously.

Screenshots showing what changed (optional)

device-2018-07-18-183232

@codecov-io
Copy link

codecov-io commented Jul 18, 2018

Codecov Report

Merging #1726 into 2.8-release will not change coverage.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           2.8-release   #1726   +/-   ##
===========================================
  Coverage         3.89%   3.89%           
===========================================
  Files              151     151           
  Lines             7521    7521           
  Branches           705     705           
===========================================
  Hits               293     293           
  Misses            7211    7211           
  Partials            17      17
Impacted Files Coverage Δ
...ain/java/fr/free/nrw/commons/auth/AccountUtil.java 0% <ø> (ø) ⬆️
...java/fr/free/nrw/commons/upload/UploadService.java 0% <0%> (ø) ⬆️
...free/nrw/commons/upload/MultipleShareActivity.java 0% <0%> (ø) ⬆️
...n/java/fr/free/nrw/commons/auth/LoginActivity.java 0% <0%> (ø) ⬆️
...ree/nrw/commons/auth/WikiAccountAuthenticator.java 0% <0%> (ø) ⬆️
...java/fr/free/nrw/commons/upload/ShareActivity.java 0% <0%> (ø) ⬆️
...w/commons/contributions/ContributionsActivity.java 0% <0%> (ø) ⬆️
.../free/nrw/commons/di/CommonsApplicationModule.java 50% <0%> (ø) ⬆️
...ommons/modifications/ModificationsSyncAdapter.java 0% <0%> (ø) ⬆️
.../nrw/commons/category/CategoryContentProvider.java 10.71% <100%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d831c0...1593622. Read the comment docs.

@misaochan
Copy link
Member

misaochan commented Jul 19, 2018

Thanks @maskaravivek , this will be quite useful.

Edited: Oh sorry, it works after running clean project. Will proceed with testing now.

@misaochan
Copy link
Member

Works well for me! This will make testing much easier. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants