Skip to content

Conversation

@VaishSiddharth
Copy link
Contributor

Title (required)

Fixes #1713 Alignment of language selection dialog in About>Translate

Description (required)

Fixes #1713

Alignment of language in about>translate

Tests performed (required)

Xiaomi Mi A1 (Android 8.0.0, API 26),

Screenshots showing what changed (optional)

screenshot_20180801-222330
screenshot_20180801-222343

@misaochan
Copy link
Member

Looks good to me! 👍 Happy to merge when tests pass.

@codecov-io
Copy link

Codecov Report

Merging #1776 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1776      +/-   ##
=========================================
- Coverage    3.63%   3.63%   -0.01%     
=========================================
  Files         182     182              
  Lines        9157    9158       +1     
  Branches      796     796              
=========================================
  Hits          333     333              
- Misses       8802    8803       +1     
  Partials       22      22
Impacted Files Coverage Δ
...c/main/java/fr/free/nrw/commons/AboutActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0678410...5098655. Read the comment docs.

@misaochan misaochan merged commit 9118733 into commons-app:master Aug 2, 2018
@misaochan
Copy link
Member

Thanks @VaishSiddharth ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants