added null check before initialising LatLng after receiving location … #1791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskaravivek
reviewed
Aug 4, 2018
maskaravivek
approved these changes
Aug 4, 2018
Codecov Report
@@ Coverage Diff @@
## master #1791 +/- ##
=========================================
- Coverage 3.56% 3.56% -0.01%
=========================================
Files 186 186
Lines 9329 9331 +2
Branches 811 812 +1
=========================================
Hits 333 333
- Misses 8974 8976 +2
Partials 22 22
Continue to review full report at Codecov.
|
ujjwalagrawal17
pushed a commit
to ujjwalagrawal17/apps-android-commons
that referenced
this pull request
Aug 8, 2018
commons-app#1791) * added null check before initialising LatLng after receiving location permission * flipped null==lastKL with lastKL==null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…permission
Nearby crash fix
Fixes #1735 [Nearby crash when LatLng is null]
Description (required)
After receiving location permission from user, while fetching last known location, we used to initialise LatLng from last known location which could be fetched from either GPS_PROVIDER or NETWORK_PROVIDER. There was a null check on the one fetched from GPS_PROVIDER but not on the one fetched from NETWORK_PROVIDER.
Fixes #1735 [Nearby crash when LatLng is null]
Added a null check on the last known location fetched from NETWORK_PROVIDER
Tests performed (required)
Tested on {27 & emulator google pixel}, with {build variant, betaDebug}.
Screenshots showing what changed (optional)
NA