Skip to content

Conversation

@misaochan
Copy link
Member

@misaochan misaochan commented Aug 4, 2018

We should not log cookie headers without informing users, due to privacy concerns. For the time being, http header logging should be restricted to debug builds (which will never be released, but can only be built manually via our repo). See https://github.com/commons-app/apps-android-commons/pull/1751/files#r205656568

Tested on Nexus One emulator on API 24, it displays http headers on debug and not on release.

@codecov-io
Copy link

Codecov Report

Merging #1795 into 2.8-release will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@              Coverage Diff               @@
##           2.8-release   #1795      +/-   ##
==============================================
- Coverage         3.65%   3.65%   -0.01%     
==============================================
  Files              186     186              
  Lines             9314    9315       +1     
  Branches           823     824       +1     
==============================================
  Hits               340     340              
  Misses            8951    8951              
- Partials            23      24       +1
Impacted Files Coverage Δ
...rw/commons/mwapi/ApacheHttpClientMediaWikiApi.java 3.75% <50%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d29aa2e...472e333. Read the comment docs.

@maskaravivek maskaravivek merged commit ff9f43e into commons-app:2.8-release Aug 4, 2018
@misaochan misaochan deleted the http-logging-only-debug branch August 4, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants