Only do http logging if a debug build is run #1795
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not log cookie headers without informing users, due to privacy concerns. For the time being, http header logging should be restricted to debug builds (which will never be released, but can only be built manually via our repo). See https://github.com/commons-app/apps-android-commons/pull/1751/files#r205656568
Tested on Nexus One emulator on API 24, it displays http headers on debug and not on release.