Skip to content

Conversation

@ujjwalagrawal17
Copy link
Contributor

Fixes #1801 (Media details view for Browse is lacking author field) in 2.8-release branch

@ujjwalagrawal17
Copy link
Contributor Author

@misaochan Please review it once. I am also testing it.

@ujjwalagrawal17
Copy link
Contributor Author

All 3 seems to be fixed.
Fixes #1805 (Expected adapter item count: 20, found: 30)
Fixes #1801 (Media details view for Browse is lacking author field)
Fixes #1519 (Swiping featured images limited to 10 images)
@nicolas-raoul @misaochan Please review it.

@misaochan
Copy link
Member

Testing now, thanks!

@misaochan
Copy link
Member

Tested on API 24 emulator, works well for me. I'll take the liberty of merging as we need to include this in the release today, @nicolas-raoul and @neslihanturan hope that's OK! :)

@misaochan misaochan merged commit bf50e74 into commons-app:2.8-release Aug 8, 2018
@codecov-io
Copy link

Codecov Report

Merging #1810 into 2.8-release will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##           2.8-release   #1810      +/-   ##
==============================================
- Coverage         3.65%   3.63%   -0.03%     
==============================================
  Files              188     188              
  Lines             9483    9540      +57     
  Branches           839     843       +4     
==============================================
  Hits               347     347              
- Misses            9112    9169      +57     
  Partials            24      24
Impacted Files Coverage Δ
...w/commons/category/CategoryImagesListFragment.java 0% <0%> (ø) ⬆️
...rw/commons/explore/images/SearchImageFragment.java 0% <0%> (ø) ⬆️
...va/fr/free/nrw/commons/explore/SearchActivity.java 0% <0%> (ø) ⬆️
...rw/commons/mwapi/ApacheHttpClientMediaWikiApi.java 3.63% <0%> (-0.03%) ⬇️
...e/nrw/commons/category/CategoryImagesActivity.java 0% <0%> (ø) ⬆️
.../nrw/commons/category/CategoryDetailsActivity.java 0% <0%> (ø) ⬆️
...w/commons/explore/images/SearchImagesRenderer.java 0% <0%> (ø) ⬆️
...ee/nrw/commons/media/MediaDetailPagerFragment.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d4e8f...919e717. Read the comment docs.

misaochan pushed a commit to misaochan/apps-android-commons that referenced this pull request Aug 8, 2018
…or field) in 2.8-release branch (commons-app#1810)

* In media search results, rotating screen triggers crash fixed commons-app#1753

* Updated API to get Author name too

* Crash fixed due to notifyDataSetChange

* search API duplicate images fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants