Bug fix issue #1839, changes #1845
Conversation
* Extracted out PageTitle object's member varaible, displayText in a variable in findTemplate() in MediaDataExtractor * added null checks for the same varaible [Lets be safe side] * replaced equals with contains, ie. displayText.contains(title), so that uploads from multiple sources which have different formats still show up coordinates which was not being shown earlier
Codecov Report
@@ Coverage Diff @@
## master #1845 +/- ##
=========================================
- Coverage 3.61% 3.61% -0.01%
=========================================
Files 192 192
Lines 9837 9838 +1
Branches 871 871
=========================================
Hits 356 356
- Misses 9455 9456 +1
Partials 26 26
Continue to review full report at Codecov.
|
|
Thanks! |
|
@nicolas-raoul Sure I will, and
, Searched for few images for which the coordinates was there on web but not on the app, and they pretty well displayed the coordinates |
|
@nicolas-raoul As you had asked, went through first 50 images in Explore, the app is stable, no crashes or issues with the coordinates |
|
Looks good to me. Merging it. Thanks @ashishkumar468 |
* Extracted out PageTitle object's member varaible, displayText in a variable in findTemplate() in MediaDataExtractor * added null checks for the same varaible [Lets be safe side] * replaced equals with contains, ie. displayText.contains(title), so that uploads from multiple sources which have different formats still show up coordinates which was not being shown earlier
Coordinates not showing up in "My Recent Uploads" picture
Fixes #{GitHub issue number #1839 and title Coordinates not showing up in "My Recent Uploads" picture }
Description
Fixes #{#1839}
The getTemplate() function in MediaDataExtractor used to extract data by searching for the elements to be shown in the ui. One of which is location. Now location for images uploaded from web and mobile had different formats for an example see
One uploaded from the app:
{{Location|12.958117388888889|77.6440805}}
One uploaded from elsewhere:
{{Location dec|47.99081|7.845416|heading:255.9}}
Clearly an exact string match for string Location would show null results for the later. So added contains instead of equals to solve the same.
Tests performed (required)
Tested on {27 & Samsung s7}, with {ProdDebug}.
Screenshots showing what changed (optional)
{Only for user interface changes, otherwise remove this section. See how to take a screenshot}
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.