Add button on image details to copy wikicode to clipboard #1849
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1849 +/- ##
=========================================
- Coverage 3.61% 3.61% -0.01%
=========================================
Files 192 192
Lines 9838 9848 +10
Branches 871 871
=========================================
Hits 356 356
- Misses 9456 9466 +10
Partials 26 26
Continue to review full report at Codecov.
|
|
Looks good to me, thanks for working on this @albendz ! A bit nitpicky, but err, should we make the two buttons (copy text and nominate for deletion) the same size? As the sizes currently look a bit off to me. Different colors should be fine since that will make it easy to distinguish between the two. |
|
I left it as a default color after a copy paste. I should have checked before: do you have UI guidelines? I'm in favor of the same size just because of how everything on this view fragment is full page width. Otherwise, I would say use a smaller button with the copy icon and no text. I can't think of a good place to put that though. |
|
Sorry, we don't have any UI guidelines per se. :) Same size would work - currently it seems to be a bit smaller than "nominate for deletion", which is probably why it looks a bit strange to me. If you wanted to use a smaller button with the copy icon, I would recommend adding an additional field (perhaps below "Description"?) that says "Use this file", and having the copy button on the left similar to the map icon in "Coordinates". |
|
Was wondering if having this in the top menu might be better? A lot of people might not be interested in this feature so I am not sure about granting it such a prominent position in the page. |
|
@maskaravivek I disagree :-) We should actively/prominently remind people that they can add pictures to WIkipedia/etc articles, because that is one of the most important uses of Commons, and the uploader is probably the best person to know how to use this picture. Also, unlike other activities we do not care too much if it gets a bit longer. |
|
I am going to make the change to have the new button width look like the nominate for deletion button width. Let me know if there is need for further discussion here. |
…ton width by filling in background
|
|
|
Looks great, thank you! |
…p#1849) * Add button on image details to copy wikicode to clipboard * Make copy wikicode button width the same as the nominate deletion button width by filling in background
…p#1849) * Add button on image details to copy wikicode to clipboard * Make copy wikicode button width the same as the nominate deletion button width by filling in background
* Sweeping update of gradle and library versions. This updates all of the dependencies of the project to their latest versions. Everyone should please upgrade to the latest version of Android Studio, update your build tools, and keep your version of Gradle and the Kotlin plugin up to date. * Update build tools in travis. * Remove cruft and fix tests. * Remove even more stuff. * Reinstate instrumented tests. * Update emulator image in travis. * Localisation updates from https://translatewiki.net. * Work towards eliminating string literals from code. (#1861) String literals are being used in many places in the code, instead of proper string resources which are automatically localized. This PR replaces many of the string literals with pre-packaged resources, or will add the appropriate string if necessary. * Add button on image details to copy wikicode to clipboard (#1849) * Add button on image details to copy wikicode to clipboard * Make copy wikicode button width the same as the nominate deletion button width by filling in background * Build fix * Enable ProGuard for Debug and Release builds. This enables ProGuard minification, which significantly shrinks the APK (for both debug and release configurations) and vastly decreases the method count. * Add ProGuard rules for test builds.
Add button on image details to copy wikicode to clipboard
Fixes #1843 Add text field to media details view for users to copy image template into Wikipedia
Description (required)
Fixes #1843 Add text field to media details view for users to copy image template into Wikipedia
Tests performed (required)
Tested on API 24, Android 7.0, Samsung S6 device
Screenshots showing what changed (optional)