Added views for button skipLogin in layout-land and layout-xLarge, bu…

[ashishkumar468]

…g fix issue#1864

LoginActivity used to crash when opened in landscape mode

Fixes #1864 and LoginActivity crashes when login screen is opened in landscape mode

Description (required)

LoginActivity used to crash when opened in landscape mode or devices supporting large density pixels
Fixes #1864 and LoginActivity crashes when login screen is opened in landscape mode

{Describe the changes made and why they were made.}
Added view btnSkipLogin (Button) in layout-land and layout-xLarge for activity_login (where there in activity login's default layout files but not in the mentioned files)

Tests performed (required)

Tested on {27 & name of pixel c tablet emulator}, with {build variant, ProdDebug}.

Screenshots showing what changed (optional)

[codecov-io]

Codecov Report

Merging #1865 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1865   +/-   ##
======================================
  Coverage    3.61%   3.61%           
======================================
  Files         188     188           
  Lines        9839    9839           
  Branches      873     873           
======================================
  Hits          356     356           
  Misses       9457    9457           
  Partials       26      26

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2efd39b...8d2a37f. Read the comment docs.

[ashishkumar468]

I went through the travis logs, seems the issue is this
commons/app/build/intermediates/res/merged/beta/debug/layout/fragment_media_detail.xml:314: error: Error: No resource found that matches the given name (at 'text' with value '@string/copy_wikicode while building, I verified that the string is there. Can someone provide some insights ?

[ashishkumar468]

There was an issue with a string nominated_see_more (still is there in master), some one had used CDATA tag for the same and missed to closed it properly [Note I had taken pull from master]. and that is why certain remaining strings were not reachable, including the one for which Codacy bot was giving me error. I have added a fix, but I am still wondering that how such a commit could surpass and go to master. Please correct me if I am mistaken somewhere. This issue might need to be merged immediately (so that other people do not face build errors). Someone please review it.

[misaochan]

Sorry about that, this has been fixed in #1868 . If you rebase on master it should work now.

Interestingly I'm not sure why the initial PR #1836 passed all the tests, both Codacy and Travis.